You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what your design goal is here. I would have expected that client.args would be the original config args unless explicitly overridden by the command line. That is what 'original' would mean to me.
But the code persists the previous values.
Maybe you want to move the save calls outside of the response handler, just inside the create() call where config comes in. Then the restore call can be unconditional every time the handler executes. That would be simpler and I think less surprising usage.
Quite a bit of karma-runner code has node modules exporting createXX functions that return functions. The arguments of the createXX functions are closed over in the returned functions.
I think you can redefine handler just before it is called in the clientArgs test, with a bonus if you wrap the non-clientArgs tests in a describe() block with beforeEach() setting handler for those tests (so the handler is not redefined.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2819.