You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When i upgraded to from Karma 0.12.x to 0.13.3, my karma setup stopped working.
file-list.js uses ES6 Array.prototype.find which of course fails with TypeError: undefined is not a function in normal node installations (without the harmony flag).
Replacing Array.prototype.find() with lodash.find() (which is already used in other places in file-list.js) seems to fix the issue.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
Use lodash find() instead of ES6 Array.prototype.find.
ES6 find is not available on standard node installations
(without the harmony flag)
Closeskarma-runner#1533
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i upgraded to from Karma 0.12.x to 0.13.3, my karma setup stopped working.
file-list.js uses ES6 Array.prototype.find which of course fails with
TypeError: undefined is not a function
in normal node installations (without the harmony flag).Replacing Array.prototype.find() with lodash.find() (which is already used in other places in file-list.js) seems to fix the issue.