Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

I signed it!

CLAs look good, thanks!

So in general I like the approach, though I would prefer not returning the globalEmitter from the start function. In my mind the code (not only yours) needs to be refactored in a way that the interacting api would look like

var karma = require('karma')
karma.on('browsers_ready', function (event) {
  // ...
})
karma.start()

but I'm not a 100% sure yet what the best way is to introduce these changes into the code base.

Thank you for taking a look at this :)

It seems quite a major undertaking to refactor everything but I agree it's the best idea longterm. I could take a stab if it's not in the near future for any of the regular maintainers.

One option to have this quickly and then still support easy migration/backwards compatibility later is to return a subset of the emitter, sort of an interface object. So something like this:

{on: globalEmitter.on.bind(globalEmitter), ...}

Then, in the future, it could just start returning karma itself. I think there's a general need to expand the public API a little bit to enable more diverse workflows.

So it turned out, it wasn't that hard to do :) see #1485 and feel free to give it a test drive

Oh, that's actually impressively quick! It seems like it will do the trick quite well. I think we're good to close this PR and the issue I mentioned if #1485 goes through. I'll play around with your branch tomorrow.

👍

Great