fix(browser): nicer "disconnect" - no more "Disconnectedundefined"

apepper · dignifiedquire · commit a987d6366f9b · 2018-03-13T11:47:20.000+01:00
The method "disconnect" sometimes is called without arguments. The emited message should not look broken then.
diff --git a/lib/browser.js b/lib/browser.js
@@ -37,7 +37,7 @@ var Browser = function (id, fullName, /* capturedBrowsers */ collection, emitter
     self.state = DISCONNECTED
     self.disconnectsCount++
     log.warn('Disconnected (%d times)' + (reason || ''), self.disconnectsCount)
-    emitter.emit('browser_error', self, 'Disconnected' + reason)
+    emitter.emit('browser_error', self, 'Disconnected' + (reason || ''))
     collection.remove(self)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ var Browser = function (id, fullName, /* capturedBrowsers */ collection, emitter`
`37`	`37`	`self.state = DISCONNECTED`
`38`	`38`	`self.disconnectsCount++`
`39`	`39`	`log.warn('Disconnected (%d times)' + (reason \|\| ''), self.disconnectsCount)`
`40`		`- emitter.emit('browser_error', self, 'Disconnected' + reason)`
	`40`	`+ emitter.emit('browser_error', self, 'Disconnected' + (reason \|\| ''))`
`41`	`41`	`collection.remove(self)`
`42`	`42`	`}`
`43`	`43`