fix(file-list): Ensure files are sorted and unique

dignifiedquire · dignifiedquire · commit 9dc5f8bc431a · 2015-07-16T21:18:45.000+02:00
This was a regression from the file-list refactoring Closes #1498, #1499
diff --git a/lib/file-list.js b/lib/file-list.js
@@ -228,7 +228,7 @@ Object.defineProperty(List.prototype, 'files', {
     })
 
     var uniqFlat = function (list) {
-      return _.uniq(_.flatten(list), true, 'path')
+      return _.uniq(_.flatten(list), 'path')
     }
 
     return {
diff --git a/test/unit/file-list.spec.coffee b/test/unit/file-list.spec.coffee
@@ -268,6 +268,24 @@ describe 'FileList', ->
         expect(file1.mtime).to.be.eql mg.statCache['/some/a.js'].mtime
         expect(file2.mtime).to.be.eql mg.statCache['/some/b.js'].mtime
 
+    it 'should sort files within buckets and keep order of patterns (buckets)', ->
+      # /a.*       => /a.txt                   [MATCH in *.txt as well]
+      # /some/*.js => /some/a.js, /some/b.js   [/some/b.js EXCLUDED]
+      # *.txt      => /c.txt, a.txt, b.txt     [UNSORTED]
+      list = new List(
+        patterns('/a.*', '/some/*.js', '*.txt'),
+        ['**/b.js'],
+        emitter,
+        preprocess
+      )
+
+      list.refresh().then (files) ->
+        expect(pathsFrom files.served).to.deep.equal [
+          '/a.txt',
+          '/some/a.js',
+          '/b.txt',
+          '/c.txt'
+        ]
 
     it 'ingores excluded files', ->
       list = new List(

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ Object.defineProperty(List.prototype, 'files', {`
`228`	`228`	`})`
`229`	`229`
`230`	`230`	`var uniqFlat = function (list) {`
`231`		`- return _.uniq(_.flatten(list), true, 'path')`
	`231`	`+ return _.uniq(_.flatten(list), 'path')`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`return {`