fix: launcher kill method which was throwing an error if no callback was specified

inspector-ambitious · inspector-ambitious · commit 5439f1cbbdce · 2013-10-06T18:18:36.000+02:00
bug introduced in 8647266 In server.js when singleRun = true, no callback is passed to when a browser complete to launcher.kill so if a browser is not yet connected but one has already finished the process throw an error. TypeError: undefined is not a function at process._tickCallback (node.js:415:13)
diff --git a/lib/launcher.js b/lib/launcher.js
@@ -53,7 +53,9 @@ var Launcher = function(emitter, injector) {
       }
     }
 
-    process.nextTick(callback);
+    if (callback) {
+      process.nextTick(callback);
+    }
     return false;
   };
 
diff --git a/test/unit/launcher.spec.coffee b/test/unit/launcher.spec.coffee
@@ -96,6 +96,13 @@ describe 'launcher', ->
         expect(l.kill 'weid-id', done).to.equal false
         expect(browser.kill).not.to.have.been.called
 
+      it 'should not resolve callback if none was defined', (done) ->
+        l.launch ['Fake']
+        browser = FakeBrowser._instances.pop()
+
+        expect(l.kill 'weid-id').to.equal false
+        process.nextTick ->
+          done()
 
     describe 'killAll', ->
       exitSpy = null

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,9 @@ var Launcher = function(emitter, injector) {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`- process.nextTick(callback);`
	`56`	`+ if (callback) {`
	`57`	`+ process.nextTick(callback);`
	`58`	`+ }`
`57`	`59`	`return false;`
`58`	`60`	`};`
`59`	`61`