feat(runner): provide error code on 'ECONNREFUSED' callback

Merott · Merott · commit 439bddb1d693 · 2015-06-03T21:23:04.000+01:00
Add the error code as the second argument to the error callback. The information
can be useful in determining what to do on error when writing plugins against
the Karma API.
diff --git a/docs/dev/04-public-api.md b/docs/dev/04-public-api.md
@@ -29,3 +29,7 @@ runner.run({port: 9876}, function(exitCode) {
   process.exit(exitCode);
 });
 ```
+
+## Callback function notes
+
+- If there is an error, the error code will be provided as the second parameter to the error callback.
diff --git a/lib/runner.js b/lib/runner.js
@@ -54,7 +54,7 @@ exports.run = function(config, done) {
   request.on('error', function(e) {
     if (e.code === 'ECONNREFUSED') {
       console.error('There is no server listening on port %d', options.port);
-      done(1);
+      done(1, e.code);
     } else {
       throw e;
     }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ exports.run = function(config, done) {`
`54`	`54`	`request.on('error', function(e) {`
`55`	`55`	`if (e.code === 'ECONNREFUSED') {`
`56`	`56`	`console.error('There is no server listening on port %d', options.port);`
`57`		`- done(1);`
	`57`	`+ done(1, e.code);`
`58`	`58`	`} else {`
`59`	`59`	`throw e;`
`60`	`60`	`}`