fix(server): Add test coverage for config.singleRun true branch. (#3384)

johnjbarton · web-flow · commit 259be0d2d0d2 · 2019-10-18T09:36:18.000-07:00
Fix async test structure. Correct logic of failOnEmptyTestSuite.
diff --git a/lib/browser_collection.js b/lib/browser_collection.js
@@ -46,8 +46,8 @@ class BrowserCollection {
     if (results.skipped && config.failOnSkippedTests) {
       return 1
     }
-    if (results.success + results.failed === 0 && !config.failOnEmptyTestSuite) {
-      return 0
+    if (results.success + results.failed === 0 && !!config.failOnEmptyTestSuite) {
+      return 1
     }
     if (results.error) {
       return 1
diff --git a/lib/server.js b/lib/server.js
@@ -283,7 +283,7 @@ class Server extends KarmaEventEmitter {
 
     const emitRunCompleteIfAllBrowsersDone = () => {
       if (Object.keys(singleRunDoneBrowsers).every((key) => singleRunDoneBrowsers[key])) {
-        this.emit('run_complete', singleRunBrowsers, singleRunBrowsers.getResults(singleRunBrowserNotCaptured, config.failOnEmptyTestSuite, config.failOnFailingTestSuite))
+        this.emit('run_complete', singleRunBrowsers, singleRunBrowsers.getResults(singleRunBrowserNotCaptured, config))
       }
     }
 
@@ -309,6 +309,8 @@ class Server extends KarmaEventEmitter {
         singleRunDoneBrowsers[completedBrowser.id] = true
         emitRunCompleteIfAllBrowsersDone()
       })
+
+      // This is the normal exit trigger.
       this.on('browser_complete_with_no_more_retries', function (completedBrowser) {
         singleRunDoneBrowsers[completedBrowser.id] = true
 
diff --git a/test/unit/browser_collection.spec.js b/test/unit/browser_collection.spec.js
@@ -274,7 +274,7 @@ describe('BrowserCollection', () => {
       const results = {
         success: 0,
         failed: 0,
-        error: true
+        error: false
       }
       it('shall pass if failOnEmptyTestSuite not is set', () => {
         const res = collection.calculateExitCode(results)
diff --git a/test/unit/server.spec.js b/test/unit/server.spec.js
@@ -42,6 +42,7 @@ describe('server', () => {
       browsers: ['fake'],
       singleRun: true,
       logLevel: 'OFF',
+      plugins: [],
       browserDisconnectTolerance: 0
     }
 
@@ -271,20 +272,92 @@ describe('server', () => {
       server.emit('browser_register', {})
       expect(browsersReady).to.have.been.called
     })
+    describe('should exit with exit code', () => {
+      let resolveExitCode
 
-    it('should exit with error exit code on load errors', async () => {
-      mockProcess(process)
+      async function exitCode () {
+        return new Promise((resolve) => {
+          resolveExitCode = resolve
+        })
+      }
+
+      it('1 on load errors', async () => {
+        mockProcess(process)
+
+        await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
+          resolveExitCode(exitCode)
+        })
+        server.loadErrors.push(['TestError', 'Test'])
+        fileListOnResolve()
+
+        function mockProcess (process) {
+          sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
+        }
 
-      await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
-        expect(exitCode).to.have.equal(1)
+        expect(await exitCode()).to.have.equal(1)
       })
 
-      server.loadErrors.push(['TestError', 'Test'])
-      fileListOnResolve()
+      it('given on run_complete', async () => {
+        mockProcess(process)
 
-      function mockProcess (process) {
-        sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
-      }
+        await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
+          resolveExitCode(exitCode)
+        })
+
+        server.emit('run_complete', browserCollection, { exitCode: 15 })
+
+        function mockProcess (process) {
+          sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
+        }
+        expect(await exitCode()).to.have.equal(15)
+      })
+
+      it('1 on browser_process_failure (singleRunBrowserNotCaptured)', async () => {
+        mockProcess(process)
+
+        await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
+          resolveExitCode(exitCode)
+        })
+
+        server.emit('browser_process_failure', { id: 'fake' })
+
+        function mockProcess (process) {
+          sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
+        }
+        expect(await exitCode()).to.have.equal(1)
+      })
+
+      it('0 on browser_complete_with_no_more_retries', async () => {
+        mockProcess(process)
+
+        await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
+          resolveExitCode(exitCode)
+        })
+
+        server.emit('browser_complete_with_no_more_retries', { id: 'fake' })
+
+        function mockProcess (process) {
+          sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
+        }
+        expect(await exitCode()).to.have.equal(0)
+      })
+
+      it('1 on browser_complete_with_no_more_retries with config.failOnEmptyTestSuite', async () => {
+        mockProcess(process)
+
+        mockConfig.failOnEmptyTestSuite = true
+
+        await server._start(mockConfig, mockLauncher, null, mockFileList, browserCollection, mockExecutor, (exitCode) => {
+          resolveExitCode(exitCode)
+        })
+
+        server.emit('browser_complete_with_no_more_retries', { id: 'fake' })
+
+        function mockProcess (process) {
+          sinon.stub(process, 'kill').callsFake((pid, ev) => process.emit(ev))
+        }
+        expect(await exitCode()).to.have.equal(1)
+      })
     })
   })
 

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,8 @@ class BrowserCollection {`
`46`	`46`	`if (results.skipped && config.failOnSkippedTests) {`
`47`	`47`	`return 1`
`48`	`48`	`}`
`49`		`- if (results.success + results.failed === 0 && !config.failOnEmptyTestSuite) {`
`50`		`- return 0`
	`49`	`+ if (results.success + results.failed === 0 && !!config.failOnEmptyTestSuite) {`
	`50`	`+ return 1`
`51`	`51`	`}`
`52`	`52`	`if (results.error) {`
`53`	`53`	`return 1`
Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ class Server extends KarmaEventEmitter {`
`283`	`283`
`284`	`284`	`const emitRunCompleteIfAllBrowsersDone = () => {`
`285`	`285`	`if (Object.keys(singleRunDoneBrowsers).every((key) => singleRunDoneBrowsers[key])) {`
`286`		`- this.emit('run_complete', singleRunBrowsers, singleRunBrowsers.getResults(singleRunBrowserNotCaptured, config.failOnEmptyTestSuite, config.failOnFailingTestSuite))`
	`286`	`+ this.emit('run_complete', singleRunBrowsers, singleRunBrowsers.getResults(singleRunBrowserNotCaptured, config))`
`287`	`287`	`}`
`288`	`288`	`}`
`289`	`289`
`@@ -309,6 +309,8 @@ class Server extends KarmaEventEmitter {`
`309`	`309`	`singleRunDoneBrowsers[completedBrowser.id] = true`
`310`	`310`	`emitRunCompleteIfAllBrowsersDone()`
`311`	`311`	`})`
	`312`	`+`
	`313`	`+ // This is the normal exit trigger.`
`312`	`314`	`this.on('browser_complete_with_no_more_retries', function (completedBrowser) {`
`313`	`315`	`singleRunDoneBrowsers[completedBrowser.id] = true`
`314`	`316`
Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ describe('BrowserCollection', () => {`
`274`	`274`	`const results = {`
`275`	`275`	`success: 0,`
`276`	`276`	`failed: 0,`
`277`		`- error: true`
	`277`	`+ error: false`
`278`	`278`	`}`
`279`	`279`	`it('shall pass if failOnEmptyTestSuite not is set', () => {`
`280`	`280`	`const res = collection.calculateExitCode(results)`