fix(web-server): inline the config, when serving debug.html

maksimr · maksimr · commit 1eb36430ca26 · 2014-04-11T20:36:27.000+04:00
diff --git a/Gruntfile.coffee b/Gruntfile.coffee
@@ -37,7 +37,6 @@ module.exports = (grunt) ->
         files: '<%= files.client %>'
         tasks: 'browserify:client'
 
-
     simplemocha:
       options:
         ui: 'bdd'
diff --git a/lib/middleware/karma.js b/lib/middleware/karma.js
@@ -54,7 +54,7 @@ var getXUACompatibleUrl = function(url) {
 };
 
 var createKarmaMiddleware = function(filesPromise, serveStaticFile,
-    /* config.basePath */ basePath,  /* config.urlRoot */ urlRoot) {
+    /* config.basePath */ basePath,  /* config.urlRoot */ urlRoot, /* config.client */ client) {
 
   return function(request, response, next) {
     var requestUrl = request.url.replace(/\?.*/, '');
@@ -130,17 +130,24 @@ var createKarmaMiddleware = function(filesPromise, serveStaticFile,
             return util.format('  \'%s\': \'%s\'', filePath, file.sha);
           });
 
+          var clientConfig = '';
+
+          if (requestUrl === '/debug.html') {
+            clientConfig = 'window.__karma__.config = ' + JSON.stringify(client) + ';\n';
+          }
+
           mappings = 'window.__karma__.files = {\n' + mappings.join(',\n') + '\n};\n';
 
           return data.
             replace('%SCRIPTS%', scriptTags.join('\n'))
+            .replace('%CLIENT_CONFIG%', clientConfig)
             .replace('%MAPPINGS%', mappings)
             .replace('\n%X_UA_COMPATIBLE%', getXUACompatibleMetaElement(request.url));
         });
       }, function(errorFiles) {
         serveStaticFile(requestUrl, response, function(data) {
           common.setNoCacheHeaders(response);
-          return data.replace('%SCRIPTS%', '').replace('%MAPPINGS%',
+          return data.replace('%SCRIPTS%', '').replace('%CLIENT_CONFIG%', '').replace('%MAPPINGS%',
               'window.__karma__.error("TEST RUN WAS CANCELLED because ' +
               (errorFiles.length > 1 ? 'these files contain' : 'this file contains') +
               ' some errors:\\n  ' + errorFiles.join('\\n  ') + '");');
diff --git a/static/debug.html b/static/debug.html
@@ -37,6 +37,8 @@
       }
     };
 
+    %CLIENT_CONFIG%
+
     // All served files with the latest timestamps
     %MAPPINGS%
   </script>
diff --git a/test/unit/middleware/karma.spec.coffee b/test/unit/middleware/karma.spec.coffee
@@ -27,10 +27,12 @@ describe 'middleware.karma', ->
   handler = filesDeferred = nextSpy = response = null
 
   beforeEach ->
+    clientConfig = foo: 'bar'
     nextSpy = sinon.spy()
     response = new HttpResponseMock
     filesDeferred = q.defer()
-    handler = createKarmaMiddleware filesDeferred.promise, serveFile, '/base/path', '/__karma__/'
+    handler = createKarmaMiddleware filesDeferred.promise, serveFile,
+      '/base/path', '/__karma__/', clientConfig
 
   # helpers
   includedFiles = (files) ->
@@ -276,6 +278,19 @@ describe 'middleware.karma', ->
     callHandlerWith '/__karma__/debug.html'
 
 
+  it 'should inline client config to debug.html', (done) ->
+    includedFiles [
+      new MockFile('/first.js')
+    ]
+    fsMock._touchFile '/karma/static/debug.html', 1, '%CLIENT_CONFIG%'
+
+    response.once 'end', ->
+      expect(response).to.beServedAs 200, 'window.__karma__.config = {"foo":"bar"};\n'
+      done()
+
+    callHandlerWith '/__karma__/debug.html'
+
+
   it 'should not serve other files even if they are in urlRoot', (done) ->
     includedFiles []
 

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@`
`37`	`37`	`}`
`38`	`38`	`};`
`39`	`39`
	`40`	`+ %CLIENT_CONFIG%`
	`41`	`+`
`40`	`42`	`// All served files with the latest timestamps`
`41`	`43`	`%MAPPINGS%`
`42`	`44`	`</script>`