feat(config): always ignore the config file itself

vojtajina · vojtajina · commit 103bc0f878a8 · 2013-03-21T16:12:14.000-07:00
It's been a very common issue, that people include the config file in the browser, which leads to unexpected errors. There is really no reason to load the config file in the browser.
diff --git a/lib/config.js b/lib/config.js
@@ -239,6 +239,9 @@ var parseConfig = function(configFilePath, cliOptions) {
   // resolve basePath
   config.basePath = path.resolve(path.dirname(configFilePath), config.basePath);
 
+  // always ignore the config file itself
+  config.exclude.push(configFilePath);
+
   return normalizeConfig(config);
 };
 
diff --git a/test/e2e/basic/karma.conf.js b/test/e2e/basic/karma.conf.js
@@ -4,10 +4,6 @@ files = [
   '*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 
 browsers = ['Chrome'];
diff --git a/test/e2e/coffee/karma.conf.js b/test/e2e/coffee/karma.conf.js
@@ -4,8 +4,6 @@ files = [
   '*.coffee'
 ];
 
-exclude = [];
-
 autoWatch = true;
 
 browsers = ['Chrome'];
diff --git a/test/e2e/coverage/karma.conf.js b/test/e2e/coverage/karma.conf.js
@@ -5,10 +5,6 @@ files = [
   'test/*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 
 browsers = ['Chrome']
diff --git a/test/e2e/coverageQunit/karma.conf.js b/test/e2e/coverageQunit/karma.conf.js
@@ -5,10 +5,6 @@ files = [
   'test/*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 
 browsers = ['Chrome'];
diff --git a/test/e2e/coverageRequirejs/karma.conf.js b/test/e2e/coverageRequirejs/karma.conf.js
@@ -5,10 +5,6 @@ files = [
   {pattern: '*.js', included: false},
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 browsers = ['Chrome'];
 singleRun = false;
diff --git a/test/e2e/junit/karma.conf.js b/test/e2e/junit/karma.conf.js
@@ -4,10 +4,6 @@ files = [
   '*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 
 browsers = ['Chrome']
diff --git a/test/e2e/mocha/karma.conf.js b/test/e2e/mocha/karma.conf.js
@@ -4,10 +4,6 @@ files = [
   '*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 browsers = ['Chrome'];
 singleRun = false;
diff --git a/test/e2e/qunit/karma.conf.js b/test/e2e/qunit/karma.conf.js
@@ -4,10 +4,6 @@ files = [
   '*.js'
 ];
 
-exclude = [
-  'karma.conf.js'
-];
-
 autoWatch = true;
 
 browsers = ['Chrome'];
diff --git a/test/e2e/requirejs/karma.conf.js b/test/e2e/requirejs/karma.conf.js
@@ -16,12 +16,6 @@ files = [
 ];
 
 
-// list of files to exclude
-exclude = [
-  'karma.conf.js'
-];
-
-
 // test results reporter to use
 // possible values: dots || progress
 reporter = 'dots';
diff --git a/test/e2e/timeout/karma.conf.ignore.js b/test/e2e/timeout/karma.conf.ignore.js
@@ -13,10 +13,6 @@ files = [
 ];
 
 
-// list of files to exclude
-exclude = [];
-
-
 // test results reporter to use
 // possible values: 'dots', 'progress', 'junit'
 reporters = ['progress'];
