Add submission caching.

hermanzdosilovic · hermanzdosilovic · commit 7a33c61c8dcb · 2020-10-17T01:39:11.000+02:00
diff --git a/app/controllers/info_controller.rb b/app/controllers/info_controller.rb
@@ -34,7 +34,7 @@ def isolate
   def statistics
     Rails.cache.delete("statistics") if params[:invalidate_cache] == "true"
     @@cache_duration ||= 10.minutes
-    Rails.cache.fetch("statistics", expires_in: @@cache_duration) do
+    render json: Rails.cache.fetch("statistics", expires_in: @@cache_duration) {
       @@language_name ||= Hash[Language.unscoped.pluck(:id, :name)]
 
       count_by_language = []
@@ -93,7 +93,6 @@ def statistics
           size_in_bytes: database_size["size_in_bytes"]
         }
       }
-    end
-    render json: Rails.cache.read("statistics")
+    }
   end
 end
diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb
@@ -55,7 +55,10 @@ def destroy
   end
 
   def show
-    render json: Submission.find_by!(token: params[:token]), base64_encoded: @base64_encoded, fields: @requested_fields
+    token = params[:token]
+    render json: Rails.cache.fetch("#{token}", expires_in: Config::SUBMISSION_CACHE_DURATION, race_condition_ttl: 0.1*Config::SUBMISSION_CACHE_DURATION) {
+      Submission.find_by!(token: token)
+    }, base64_encoded: @base64_encoded, fields: @requested_fields
   rescue Encoding::UndefinedConversionError
     render_conversion_error(:bad_request)
   end
diff --git a/app/helpers/config.rb b/app/helpers/config.rb
@@ -2,8 +2,8 @@ module Config
   # For more info read:
   # https://github.com/judge0/judge0/blob/master/judge0.conf
 
-  MAINTENANCE_MODE = ENV['MAINTENANCE_MODE'] == "true"
-  ENABLE_WAIT_RESULT = ENV['ENABLE_WAIT_RESULT'] != "false"
+  MAINTENANCE_MODE = ENV["MAINTENANCE_MODE"] == "true"
+  ENABLE_WAIT_RESULT = ENV["ENABLE_WAIT_RESULT"] != "false"
   ENABLE_COMPILER_OPTIONS = ENV["ENABLE_COMPILER_OPTIONS"] != "false"
   ALLOWED_LANGUAGES_FOR_COMPILER_OPTIONS = ENV["ALLOWED_LANGUAGES_FOR_COMPILER_OPTIONS"].to_s.strip.split
   ENABLE_COMMAND_LINE_ARGUMENTS = ENV["ENABLE_COMMAND_LINE_ARGUMENTS"] != "false"
@@ -12,31 +12,32 @@ module Config
   CALLBACKS_MAX_TRIES = (ENV["CALLBACKS_MAX_TRIES"].presence || 3).to_i
   CALLBACKS_TIMEOUT = (ENV["CALLBACKS_TIMEOUT"].presence || 5).to_f
   ENABLE_ADDITIONAL_FILES = ENV["ENABLE_ADDITIONAL_FILES"] != "false"
-  MAX_QUEUE_SIZE = (ENV['MAX_QUEUE_SIZE'].presence || 100).to_i
-  CPU_TIME_LIMIT = (ENV['CPU_TIME_LIMIT'].presence || 5).to_f
-  MAX_CPU_TIME_LIMIT = (ENV['MAX_CPU_TIME_LIMIT'].presence || 15).to_f
-  CPU_EXTRA_TIME = (ENV['CPU_EXTRA_TIME'].presence || 1).to_f
-  MAX_CPU_EXTRA_TIME = (ENV['MAX_CPU_EXTRA_TIME'].presence || 5).to_f
-  WALL_TIME_LIMIT = (ENV['WALL_TIME_LIMIT'].presence || 10).to_f
-  MAX_WALL_TIME_LIMIT = (ENV['MAX_WALL_TIME_LIMIT'].presence || 20).to_f
-  MEMORY_LIMIT = (ENV['MEMORY_LIMIT'].presence || 128000).to_i # in KB
-  MAX_MEMORY_LIMIT = (ENV['MAX_MEMORY_LIMIT'].presence || 512000).to_i
-  STACK_LIMIT = (ENV['STACK_LIMIT'].presence || 64000).to_i # in KB
-  MAX_STACK_LIMIT = (ENV['MAX_STACK_LIMIT'].presence || 128000).to_i
-  MAX_PROCESSES_AND_OR_THREADS = (ENV['MAX_PROCESSES_AND_OR_THREADS'].presence || 60).to_i
-  MAX_MAX_PROCESSES_AND_OR_THREADS = (ENV['MAX_MAX_PROCESSES_AND_OR_THREADS'].presence || 120).to_i
-  ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT = ENV['ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT'] == "true"
-  ALLOW_ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT = ENV['ALLOW_ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT'] != "false"
-  ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT = ENV['ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT'] == "true"
-  ALLOW_ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT = ENV['ALLOW_ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT'] != "false"
-  MAX_FILE_SIZE = (ENV['MAX_FILE_SIZE'].presence || 1024).to_i
-  MAX_MAX_FILE_SIZE = (ENV['MAX_MAX_FILE_SIZE'].presence || 4096).to_i
-  NUMBER_OF_RUNS = (ENV['NUMBER_OF_RUNS'].presence || 1).to_i
-  MAX_NUMBER_OF_RUNS = (ENV['MAX_NUMBER_OF_RUNS'].presence || 20).to_i
-  REDIRECT_STDERR_TO_STDOUT = ENV['REDIRECT_STDERR_TO_STDOUT'] == "true"
-  MAX_EXTRACT_SIZE = (ENV['MAX_EXTRACT_SIZE'].presence || 10240).to_i
+  MAX_QUEUE_SIZE = (ENV["MAX_QUEUE_SIZE"].presence || 100).to_i
+  CPU_TIME_LIMIT = (ENV["CPU_TIME_LIMIT"].presence || 5).to_f
+  MAX_CPU_TIME_LIMIT = (ENV["MAX_CPU_TIME_LIMIT"].presence || 15).to_f
+  CPU_EXTRA_TIME = (ENV["CPU_EXTRA_TIME"].presence || 1).to_f
+  MAX_CPU_EXTRA_TIME = (ENV["MAX_CPU_EXTRA_TIME"].presence || 5).to_f
+  WALL_TIME_LIMIT = (ENV["WALL_TIME_LIMIT"].presence || 10).to_f
+  MAX_WALL_TIME_LIMIT = (ENV["MAX_WALL_TIME_LIMIT"].presence || 20).to_f
+  MEMORY_LIMIT = (ENV["MEMORY_LIMIT"].presence || 128000).to_i # in KB
+  MAX_MEMORY_LIMIT = (ENV["MAX_MEMORY_LIMIT"].presence || 512000).to_i
+  STACK_LIMIT = (ENV["STACK_LIMIT"].presence || 64000).to_i # in KB
+  MAX_STACK_LIMIT = (ENV["MAX_STACK_LIMIT"].presence || 128000).to_i
+  MAX_PROCESSES_AND_OR_THREADS = (ENV["MAX_PROCESSES_AND_OR_THREADS"].presence || 60).to_i
+  MAX_MAX_PROCESSES_AND_OR_THREADS = (ENV["MAX_MAX_PROCESSES_AND_OR_THREADS"].presence || 120).to_i
+  ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT = ENV["ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT"] == "true"
+  ALLOW_ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT = ENV["ALLOW_ENABLE_PER_PROCESS_AND_THREAD_TIME_LIMIT"] != "false"
+  ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT = ENV["ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT"] == "true"
+  ALLOW_ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT = ENV["ALLOW_ENABLE_PER_PROCESS_AND_THREAD_MEMORY_LIMIT"] != "false"
+  MAX_FILE_SIZE = (ENV["MAX_FILE_SIZE"].presence || 1024).to_i
+  MAX_MAX_FILE_SIZE = (ENV["MAX_MAX_FILE_SIZE"].presence || 4096).to_i
+  NUMBER_OF_RUNS = (ENV["NUMBER_OF_RUNS"].presence || 1).to_i
+  MAX_NUMBER_OF_RUNS = (ENV["MAX_NUMBER_OF_RUNS"].presence || 20).to_i
+  REDIRECT_STDERR_TO_STDOUT = ENV["REDIRECT_STDERR_TO_STDOUT"] == "true"
+  MAX_EXTRACT_SIZE = (ENV["MAX_EXTRACT_SIZE"].presence || 10240).to_i
   ENABLE_BATCHED_SUBMISSIONS = ENV["ENABLE_BATCHED_SUBMISSIONS"] != "false"
-  MAX_SUBMISSION_BATCH_SIZE = (ENV['MAX_SUBMISSION_BATCH_SIZE'].presence || 20).to_i
+  MAX_SUBMISSION_BATCH_SIZE = (ENV["MAX_SUBMISSION_BATCH_SIZE"].presence || 20).to_i
+  SUBMISSION_CACHE_DURATION = (ENV["SUBMISSION_CACHE_DURATION"].presence || 1).to_f
 
   def self.config_info
     @@default_confg ||= {
@@ -74,7 +75,8 @@ def self.config_info
       "redirect_stderr_to_stdout": REDIRECT_STDERR_TO_STDOUT,
       "max_extract_size": MAX_EXTRACT_SIZE,
       "enable_batched_submissions": ENABLE_BATCHED_SUBMISSIONS,
-      "max_submission_batch_size": MAX_SUBMISSION_BATCH_SIZE
+      "max_submission_batch_size": MAX_SUBMISSION_BATCH_SIZE,
+      "submission_cache_duration": SUBMISSION_CACHE_DURATION
     }
   end
 end
diff --git a/judge0.conf b/judge0.conf
@@ -84,6 +84,12 @@ CALLBACKS_TIMEOUT=
 # Default: true
 ENABLE_ADDITIONAL_FILES=
 
+# Duration (in seconds) of submission cache. Decimal numbers are allowed.
+# Set to 0 to turn of submission caching. Note that this does not apply to
+# batched submissions.
+# Default: 1
+SUBMISSION_CACHE_DURATION=
+
 
 ################################################################################
 # Judge0 Workers Configuration
