Add support for network calls in run time.

hermanzdosilovic · hermanzdosilovic · commit 62a00520692c · 2021-03-08T18:00:01.000+01:00
diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb
@@ -176,7 +176,8 @@ def submission_params(params)
       :max_file_size,
       :redirect_stderr_to_stdout,
       :callback_url,
-      :additional_files
+      :additional_files,
+      :enable_network
     )
 
     submission_params[:additional_files] = Base64Service.decode(submission_params[:additional_files])
diff --git a/app/helpers/config.rb b/app/helpers/config.rb
@@ -39,6 +39,8 @@ module Config
   MAX_SUBMISSION_BATCH_SIZE = (ENV["MAX_SUBMISSION_BATCH_SIZE"].presence || 20).to_i
   SUBMISSION_CACHE_DURATION = (ENV["SUBMISSION_CACHE_DURATION"].presence || 1).to_f
   USE_DOCS_AS_HOMEPAGE = ENV["USE_DOCS_AS_HOMEPAGE"] == "true"
+  ALLOW_ENABLE_NETWORK = ENV["ALLOW_ENABLE_NETWORK"] != "false"
+  ENABLE_NETWORK = ENV["ENABLE_NETWORK"] == "true"
 
   def self.config_info
     @@default_confg ||= {
@@ -78,7 +80,9 @@ def self.config_info
       "enable_batched_submissions": ENABLE_BATCHED_SUBMISSIONS,
       "max_submission_batch_size": MAX_SUBMISSION_BATCH_SIZE,
       "submission_cache_duration": SUBMISSION_CACHE_DURATION,
-      "use_docs_as_homepage": USE_DOCS_AS_HOMEPAGE
+      "use_docs_as_homepage": USE_DOCS_AS_HOMEPAGE,
+      "allow_enable_network": ALLOW_ENABLE_NETWORK,
+      "enable_network": ENABLE_NETWORK
     }
   end
 end
diff --git a/app/jobs/isolate_job.rb b/app/jobs/isolate_job.rb
@@ -205,6 +205,7 @@ def run
     -b #{box_id} \
     -M #{metadata_file} \
     #{submission.redirect_stderr_to_stdout ? "--stderr-to-stdout" : ""} \
+    #{submission.enable_network ? "--share-net" : ""} \
     -t #{submission.cpu_time_limit} \
     -x #{submission.cpu_extra_time} \
     -w #{submission.wall_time_limit} \
diff --git a/app/models/submission.rb b/app/models/submission.rb
@@ -32,6 +32,10 @@
 #  wall_time                                  :decimal(, )
 #  compiler_options                           :string
 #  command_line_arguments                     :string
+#  redirect_stderr_to_stdout                  :boolean
+#  callback_url                               :string
+#  additional_files                           :binary
+#  enable_network                             :boolean
 #
 # Indexes
 #
@@ -69,7 +73,7 @@ class Submission < ApplicationRecord
   validates :command_line_arguments, length: { maximum: 512 }
   validate :language_existence, :compiler_options_allowed,
            :command_line_arguments_allowed, :callbacks_allowed,
-           :additional_files_allowed
+           :additional_files_allowed, :network_allowed
 
   before_create :generate_token
   before_validation :set_defaults
@@ -212,6 +216,14 @@ def additional_files_allowed
     end
   end
 
+  def network_allowed
+    return if enable_network.blank?
+
+    unless Config::ALLOW_ENABLE_NETWORK
+      errors.add(:enable_network, "enabling network is not allowed")
+    end
+  end
+
   def generate_token
     begin
       self.token = SecureRandom.uuid
@@ -240,5 +252,9 @@ def set_defaults
       self.redirect_stderr_to_stdout,
       Config::REDIRECT_STDERR_TO_STDOUT
     )
+    self.enable_network = NilValue.value_or_default(
+      self.enable_network,
+      Config::ENABLE_NETWORK
+    )
   end
 end
diff --git a/db/migrate/20210308152656_add_enable_network_to_submissions.rb b/db/migrate/20210308152656_add_enable_network_to_submissions.rb
@@ -0,0 +1,5 @@
+class AddEnableNetworkToSubmissions < ActiveRecord::Migration[5.2]
+  def change
+    add_column :submissions, :enable_network, :boolean
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_03_27_224155) do
+ActiveRecord::Schema.define(version: 2021_03_08_152656) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -59,6 +59,7 @@
     t.boolean "redirect_stderr_to_stdout"
     t.string "callback_url"
     t.binary "additional_files"
+    t.boolean "enable_network"
     t.index ["token"], name: "index_submissions_on_token"
   end
 
diff --git a/docs/api/submissions/submissions.md b/docs/api/submissions/submissions.md
@@ -3,10 +3,10 @@
 Submission is used for running arbitrary source code in one of
 the [available programming languages](#statuses-and-languages-language-get) with specified runtime constraints.
 
-Submission has 32 attributes. Attributes 1-19 are used for creating a new submissions, whereas
-attributes 20-32 give detailed information of submission after it's execution.
+Submission has 33 attributes. Attributes 1-20 are used for creating a new submissions, whereas
+attributes 21-33 give detailed information of submission after it's execution.
 
-Attributes 7-17 are called [*configuration variables*](#system-and-configuration-configuration-info)
+Attributes 7-18 are called [*configuration variables*](#system-and-configuration-configuration-info)
 and can be used to configure submission runtime constraints such as time and memory limits.
 
 |#    |Name |Type  |Unit  |Description |Default Value |
@@ -27,22 +27,23 @@ and can be used to configure submission runtime constraints such as time and mem
 |14|`enable_per_process_and_thread_memory_limit`|boolean||If `true` then `memory_limit` will be used as per process and thread.|Depends on [configuration](#system-and-configuration-configuration-info).|
 |15|`max_file_size`|integer|kilobyte|Limit file size created or modified by the program.|Depends on [configuration](#system-and-configuration-configuration-info).|
 |16|`redirect_stderr_to_stdout`|boolean||If `true` standard error will be redirected to standard output.|Depends on [configuration](#system-and-configuration-configuration-info).|
-|17|`number_of_runs`|integer||Run each program `number_of_runs` times and take average of `time` and `memory`.|Depends on [configuration](#system-and-configuration-configuration-info).|
-|18|**`additional_files`**|Base64 Encoded String||Additional files that should be available alongside the source code. Value of this string should represent the content of a `.zip` that contains additional files. This attribute is **required** for [multi-file programs](#header-single-file-programs-and-multi-file-programs).|`null`|
-|19|`callback_url`|string||URL on which Judge0 will issue `PUT` request with the submission in a request body after submission has been done.|`null`|
-|20|`stdout`|text||Standard output of the program after execution.||
-|21|`stderr`|text||Standard error of the program after execution.||
-|22|`compile_output`|text||Compiler output after compilation.||
-|23|`message`|text||If submission status is `Internal Error` then this message comes from Judge0 itself, otherwise this is status message from [isolate](https://github.com/ioi/isolate).||
-|24|`exit_code`|integer||The program's exit code.||
-|25|`exit_signal`|integer||Signal code that the program recieved before exiting.||
-|26|`status`|object||Submission [status](#statuses-and-languages-status).||
-|27|`created_at`|datetime||Date and time when submission was created.||
-|28|`finished_at`|datetime||Date and time when submission was processed.|`null` if submission is still in queue or if submission is processing.|
-|29|`token`|string||Unique submission token which can be used to [get a specific submission](#submissions-submission-get).||
-|30|`time`|float|second|Program's run time.||
-|31|`wall_time`|float|second|Program's wall time. Will be greater or equal to `time`.||
-|32|`memory`|float|kilobyte|Memory used by the program after execution.||
+|17|`enable_network`|boolean||If `true` program will have network access.|Depends on [configuration](#system-and-configuration-configuration-info).|
+|18|`number_of_runs`|integer||Run each program `number_of_runs` times and take average of `time` and `memory`.|Depends on [configuration](#system-and-configuration-configuration-info).|
+|19|**`additional_files`**|Base64 Encoded String||Additional files that should be available alongside the source code. Value of this string should represent the content of a `.zip` that contains additional files. This attribute is **required** for [multi-file programs](#header-single-file-programs-and-multi-file-programs).|`null`|
+|20|`callback_url`|string||URL on which Judge0 will issue `PUT` request with the submission in a request body after submission has been done.|`null`|
+|21|`stdout`|text||Standard output of the program after execution.||
+|22|`stderr`|text||Standard error of the program after execution.||
+|23|`compile_output`|text||Compiler output after compilation.||
+|24|`message`|text||If submission status is `Internal Error` then this message comes from Judge0 itself, otherwise this is status message from [isolate](https://github.com/ioi/isolate).||
+|25|`exit_code`|integer||The program's exit code.||
+|26|`exit_signal`|integer||Signal code that the program recieved before exiting.||
+|27|`status`|object||Submission [status](#statuses-and-languages-status).||
+|28|`created_at`|datetime||Date and time when submission was created.||
+|29|`finished_at`|datetime||Date and time when submission was processed.|`null` if submission is still in queue or if submission is processing.|
+|30|`token`|string||Unique submission token which can be used to [get a specific submission](#submissions-submission-get).||
+|31|`time`|float|second|Program's run time.||
+|32|`wall_time`|float|second|Program's wall time. Will be greater or equal to `time`.||
+|33|`memory`|float|kilobyte|Memory used by the program after execution.||
 
 ### Single-file programs and multi-file programs
 Judge0 can run both single-file and multi-file programs in a sandboxed environment with specified resource limitations.
diff --git a/docs/api/system_and_configuration/configuration_info.md b/docs/api/system_and_configuration/configuration_info.md
@@ -29,7 +29,9 @@ if admin didn't set them. For example, default value of *configuration variable*
 |13|`enable_per_process_and_thread_time_limit`|boolean||If `true` then `cpu_time_limit` will be used as per process and thread.|false|
 |14|`enable_per_process_and_thread_memory_limit`|boolean||If `true` then `memory_limit` will be used as per process and thread.|true|
 |15|`max_file_size`|integer|kilobyte|Limit size of files created (or modified) by the program.|1024|
-|16|`number_of_runs`|integer||Run each program this many times and take average of time and memory.|1|
+|16|`allow_enable_network`|boolean||If enabled user can set `enable_network`.|true|
+|17|`enable_network`|boolean||If enabled program will have network access.|true|
+|18|`number_of_runs`|integer||Run each program this many times and take average of time and memory.|1|
 
 *Default configuration value* for each variable is given to you as response of this API call. For example, *default configuration value*
 for variable `cpu_extra_time` might be `2`, and if admin didn't set this, then it is `0.5` (*default value*).
diff --git a/judge0.conf b/judge0.conf
@@ -328,6 +328,14 @@ REDIRECT_STDERR_TO_STDOUT=
 # Default: 10240, i.e. maximum of 10MB in total can be extracted.
 MAX_EXTRACT_SIZE=
 
+# If false, user won't be able to set ENABLE_NETWORK.
+# Default: true, i.e. allow user to permit or deny network calls from the submission.
+ALLOW_ENABLE_NETWORK=
+
+# If true submission will by default be able to do network calls.
+# Default: false, i.e. programs cannot do network calls.
+ENABLE_NETWORK=
+
 
 ################################################################################
 # Rails Configuration
diff --git a/public/docs.html b/public/docs.html
diff --git a/public/dummy-client.html b/public/dummy-client.html

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,8 @@ def submission_params(params)`
`176`	`176`	`:max_file_size,`
`177`	`177`	`:redirect_stderr_to_stdout,`
`178`	`178`	`:callback_url,`
`179`		`- :additional_files`
	`179`	`+ :additional_files,`
	`180`	`+ :enable_network`
`180`	`181`	`)`
`181`	`182`
`182`	`183`	`submission_params[:additional_files] = Base64Service.decode(submission_params[:additional_files])`