Selector:Manipulation: Fix DOM manip within template contents #5159

mgol · 2022-11-15T14:47:57Z

Summary

The <template/> element contents property is a document fragment that may have a null documentElement. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now.

The crash used to happen in jQuery.contains which is an alias for Sizzle.contains in jQuery 3.x.

The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's 3.x-stable branch and backports one test from gh-5158.

Fixes gh-5147
Ref jquery/sizzle/pull/490
Ref gh-5158

Checklist

New tests have been added to show the fix or feature works
Grunt build and unit tests pass locally with these changes
~~If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com~~
Update Sizzle to a version including PR: Core: Make Sizzle.contains work within <template/> elements sizzle#490

Fixes jquerygh-5147 Ref jquerygh-5158 Ref jquery/sizzle#490

The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's `3.x-stable` branch and backports one test from jquerygh-5158. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158

The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158

The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. A fix similar to the one from jquerygh-5158 has also been applied here to the `selector-native` version. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158

mgol · 2022-11-16T16:07:20Z

@timmywil I also had to apply a fix to selector-native to pass this new test. I opted to skip documentElement there, similarly to the fix on jQuery master since documentElement only mattered in IE <9.

mgol added Manipulation Selector Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Nov 15, 2022

mgol added this to the 3.6.2 milestone Nov 15, 2022

mgol self-assigned this Nov 15, 2022

mgol mentioned this pull request Nov 15, 2022

Safari 16 crashes on in-template DOM manipulation #5147

Closed

timmywil approved these changes Nov 15, 2022

View reviewed changes

mgol removed Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Nov 16, 2022

Selector: Update Sizzle from 2.3.7 to 2.3.8

bc78d56

Fixes jquerygh-5147 Ref jquerygh-5158 Ref jquery/sizzle#490

mgol force-pushed the 3.x-template-manip-fixes branch from 1f6c175 to ffdd09b Compare November 16, 2022 15:58

mgol force-pushed the 3.x-template-manip-fixes branch from ffdd09b to 5e40c14 Compare November 16, 2022 15:59

mgol force-pushed the 3.x-template-manip-fixes branch from 5e40c14 to bc23c1c Compare November 16, 2022 16:06

mgol merged commit 5318e31 into jquery:3.x-stable Nov 16, 2022

mgol deleted the 3.x-template-manip-fixes branch November 16, 2022 22:58

github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Selector:Manipulation: Fix DOM manip within template contents #5159

Selector:Manipulation: Fix DOM manip within template contents #5159

Uh oh!

mgol commented Nov 15, 2022 •

edited

Loading

Uh oh!

mgol commented Nov 16, 2022

Uh oh!

Uh oh!

Selector:Manipulation: Fix DOM manip within template contents #5159

Selector:Manipulation: Fix DOM manip within template contents #5159

Uh oh!

Conversation

mgol commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

mgol commented Nov 16, 2022

Uh oh!

Uh oh!

mgol commented Nov 15, 2022 •

edited

Loading