| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 00:13:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=380.20782,conversation_content-fragment;desc="conversation_content fragment";dur=578.147568,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=266.893267,nginx;desc="NGINX";dur=1.506071,glb;desc="GLB";dur=137.606969
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=k98DBT0IFH1qvZuldEvHz9L52mIvXGCJa1Qw0mBl4lYV5KfaladmmSfjfdIaYz6gJN%2BqGYk5Ef%2F1i%2BPC%2F%2FYOUBdp%2BgblmtrolOVJMHDfRaUzpYDKUDlnV%2BoAH0zNliwJnd%2FBqR%2F2b4x%2BFrJilvrezfKIuxXPYcv%2BGd2F6oYA1vwlNP23uaWXKgSY4wMe6wkzMl40Kgf%2FXHXv4a6Upidd7GTkj5PYaq8gCgKMqkHPiNNsMf5t6iV2nfxkiMgmpaeMqLZPs6wZ%2BW%2FoftdI3KYrTQ%3D%3D--rN%2B%2BncC7t6MgTg2H--40jCHfxXn7I%2B7xxkANuWeQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2026287929.1760055197; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 00:13:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 00:13:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CCF6:1F91AB:FD87BB:12EA93B:68E84F9D
Effects: Remove jQuery.fx.interval by mgol · Pull Request #5017 · jquery/jquery · GitHub
mgol
force-pushed
the
fx-interval-removal
branch
from
February 28, 2022 18:06
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Effects: Remove jQuery.fx.interval #5017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+155
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is meant to represent the `jQuery.fx.interval` value. In a future commit, it's going to be set to `13` and `jQuery.fx.interval` will no longer be defined.
`jQuery.fx.interval` has been deprecated since jQuery 3.0.0 but it has been still used in jQuery code until this change.
mgol
force-pushed
the
fx-interval-removal
branch
from
de8ca2b to
0ab05d2
Compare
timmywil
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
jQuery.fx.intervalhas been deprecated since jQuery 3.0.0 but it has beenstill used in jQuery code until this change.
The PR is divided into two commits. The first one just updates tests to parametrize them by a local
fxIntervalvariable that's supposed to imitatejQuery.fx.interval. The second commit updates the source to removejQuery.fx.intervaland changes the value offxIntervalin tests from 10 to 13 as it's no longer possible to tweak this value which has been done until now.Each of the commits passes tests.
Fixes gh-4018
-12 bytes 🎉
Checklist