CARVIEW |
Select Language
HTTP/2 200
date: Wed, 08 Oct 2025 07:16:23 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=268.173563,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=749.098109,nginx;desc="NGINX";dur=1.034827,glb;desc="GLB";dur=141.530724
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Qb7PJovYP3qp7dCtaM7dlWjGYbyhd00PKPvKL8InRZdK3qTovTKs0OIxxPtFVcMyVa4A92aNltNNgJCpt36Y8bZHuqJJv0WZlFGlm3PyB0raWA1Li21vEZYmoEXGcbn2TiMLewSRMNANBGIIM7OVVIwLtC022spo%2BK1TdK0Hi0XbQr1yQKfJQzO6ngsDI30N68ZOb79iVYGa7N%2FFopVDxLhs30nD9EVOaa5liPvnMY4zR0PrWW%2BgLij47bhxgzR3RHyVNm89rNohryHIjbFTQA%3D%3D--C1FFikrX5wer90ND--MHtTfn8OfRBsRHSQCh%2B%2FZw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2047200405.1759907782; Path=/; Domain=github.com; Expires=Thu, 08 Oct 2026 07:16:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 08 Oct 2026 07:16:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C304:3ABF9F:1BCB28:1EAFBC:68E60FC6
Drop `toggleClass(boolean)` and `toggleClass(undefined)` signatures Β· Issue #3388 Β· jquery/jquery Β· GitHub
No one assignedNo typeNo projectsNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Closed
Milestone
Description
Can we evaluate if these signatures can be dropped? Here's a few arguments:
- It can mask bugs when the first argument inadvertently evaluates to
undefined
, which results in all classes being removed the first time it is called. - It's badly documented (Misleading documentation for toggleClass() method.Β #1696) and because of that, probably not well-known.
- The way it saves a
__className__
data seems like a bad practice. - For custom builds, it creates a otherwise unnecessary dependency for
attributes/classes
towardsdata
. - It would allow the following savings for full builds:
raw gz Compared to master @ 5b4cb0d33731a58384e02ad51e703e7dcb00e424
-701 -230 dist/jquery.js
-168 -61 dist/jquery.min.js
Florian-R, dmethvin and ExE-Boss
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
Issue actions
You canβt perform that action at this time.