Build: Require strict mode in Node.js scripts via ESLint

mgol · mgol · commit ac2da4e6b96f · 2019-10-09T00:24:17.000+02:00
So far, only browser-based JS files were required to be in strict mode (in the function form). This commit adds such a requirement to Node.js scripts where the global form is preferred. All Node.js scripts in sloppy mode were converted to strict mode. Closes gh-4499 (cherry picked from commit bbad821)
diff --git a/.eslintrc-node.json b/.eslintrc-node.json
@@ -10,5 +10,9 @@
 	"env": {
 		"es6": true,
 		"node": true
+	},
+
+	"rules": {
+		"strict": ["error", "global"]
 	}
 }
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -1,6 +1,6 @@
-module.exports = function( grunt ) {
-	"use strict";
+"use strict";
 
+module.exports = function( grunt ) {
 	function readOptionalJSON( filepath ) {
 		var stripJSONComments = require( "strip-json-comments" ),
 			data = {};
diff --git a/build/release.js b/build/release.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( Release ) {
diff --git a/build/release/cdn.js b/build/release/cdn.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var
 	fs = require( "fs" ),
 	shell = require( "shelljs" ),
diff --git a/build/release/dist.js b/build/release/dist.js
@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = function( Release, files, complete ) {
 
 	var
diff --git a/build/release/ensure-sizzle.js b/build/release/ensure-sizzle.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" ),
 	npm = require( "npm" ),
 	chalk = require( "chalk" ),
diff --git a/build/tasks/build.js b/build/tasks/build.js
@@ -4,10 +4,9 @@
  * and includes/excludes specified modules
  */
 
-module.exports = function( grunt ) {
-
-	"use strict";
+"use strict";
 
+module.exports = function( grunt ) {
 	var fs = require( "fs" ),
 		requirejs = require( "requirejs" ),
 		Insight = require( "insight" ),
diff --git a/build/tasks/dist.js b/build/tasks/dist.js
@@ -1,7 +1,6 @@
-module.exports = function( grunt ) {
-
-	"use strict";
+"use strict";
 
+module.exports = function( grunt ) {
 	var	fs = require( "fs" ),
 		filename = grunt.option( "filename" ),
 		distpaths = [
diff --git a/build/tasks/node_smoke_tests.js b/build/tasks/node_smoke_tests.js
@@ -1,7 +1,6 @@
-module.exports = ( grunt ) => {
-
-	"use strict";
+"use strict";
 
+module.exports = ( grunt ) => {
 	const fs = require( "fs" );
 	const spawnTest = require( "./lib/spawn_test.js" );
 	const testsDir = "./test/node_smoke_tests/";
diff --git a/build/tasks/qunit_fixture.js b/build/tasks/qunit_fixture.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( grunt ) {
diff --git a/build/tasks/sourcemap.js b/build/tasks/sourcemap.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( grunt ) {
diff --git a/build/tasks/testswarm.js b/build/tasks/testswarm.js
@@ -1,7 +1,6 @@
-module.exports = function( grunt ) {
-
-	"use strict";
+"use strict";
 
+module.exports = function( grunt ) {
 	grunt.registerTask( "testswarm", function( commit, configFile, projectName, browserSets,
 			timeout, testMode ) {
 		var jobName, config, tests,

Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,9 @@`
`10`	`10`	`"env": {`
`11`	`11`	`"es6": true,`
`12`	`12`	`"node": true`
	`13`	`+ },`
	`14`	`+`
	`15`	`+ "rules": {`
	`16`	`+ "strict": ["error", "global"]`
`13`	`17`	`}`
`14`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+"use strict";`
	`2`	`+`
`1`	`3`	`var fs = require( "fs" );`
`2`	`4`
`3`	`5`	`module.exports = function( Release ) {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+"use strict";`
	`2`	`+`
`1`	`3`	`var`
`2`	`4`	`fs = require( "fs" ),`
`3`	`5`	`shell = require( "shelljs" ),`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+"use strict";`
	`2`	`+`
`1`	`3`	`module.exports = function( Release, files, complete ) {`
`2`	`4`
`3`	`5`	`var`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+"use strict";`
	`2`	`+`
`1`	`3`	`var fs = require( "fs" ),`
`2`	`4`	`npm = require( "npm" ),`
`3`	`5`	`chalk = require( "chalk" ),`