Effect: Fix a unnecessary conditional statement in .stop()

wonseop · mgol · commit 30f5c6c3ee3a · 2019-09-26T01:14:38.000+02:00
Because of the above conditional, the 'type' variable has a value of type 'string' or undefined. Therefore, boolean comparisons for 'type' variable is always unnecessary because it return true. The patch removed the unnecessary conditional statement. Fixes gh-4374 Closes gh-4375 (cherry picked from commit 110802c)
diff --git a/src/effects.js b/src/effects.js
@@ -542,7 +542,7 @@ jQuery.fn.extend( {
 			clearQueue = type;
 			type = undefined;
 		}
-		if ( clearQueue && type !== false ) {
+		if ( clearQueue ) {
 			this.queue( type || "fx", [] );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -542,7 +542,7 @@ jQuery.fn.extend( {`
`542`	`542`	`clearQueue = type;`
`543`	`543`	`type = undefined;`
`544`	`544`	`}`
`545`		`- if ( clearQueue && type !== false ) {`
	`545`	`+ if ( clearQueue ) {`
`546`	`546`	`this.queue( type \|\| "fx", [] );`
`547`	`547`	`}`
`548`	`548`