fix: show the file sizes in KB (see #537)

josdejong · josdejong · commit 216b7091c583 · 2025-03-26T12:09:14.000+01:00
diff --git a/src/lib/components/modes/textmode/TextMode.svelte b/src/lib/components/modes/textmode/TextMode.svelte
@@ -1131,14 +1131,8 @@
       <Message
         icon={faExclamationTriangle}
         type="error"
-        message={`The JSON document is larger than ${formatSize(
-          MAX_DOCUMENT_SIZE_TEXT_MODE,
-          1024
-        )}, ` +
-          `and may crash your browser when loading it in text mode. Actual size: ${formatSize(
-            text.length,
-            1024
-          )}.`}
+        message={`The JSON document is larger than ${formatSize(MAX_DOCUMENT_SIZE_TEXT_MODE)}, ` +
+          `and may crash your browser when loading it in text mode. Actual size: ${formatSize(text.length)}.`}
         actions={[
           {
             text: 'Open anyway',
diff --git a/src/lib/utils/fileUtils.test.ts b/src/lib/utils/fileUtils.test.ts
@@ -13,8 +13,4 @@ describe('fileUtils', () => {
     assert.strictEqual(formatSize(22.37 * 1000 * 1000 * 1000), '22.4 GB')
     assert.strictEqual(formatSize(1000 * 1000 * 1000 * 1000), '1.0 TB')
   })
-
-  test('should format a document size in a human readable way counting with 1024', () => {
-    assert.strictEqual(formatSize(1024 * 1024, 1024), '1.0 MB')
-  })
 })
diff --git a/src/lib/utils/fileUtils.ts b/src/lib/utils/fileUtils.ts
@@ -1,28 +1,30 @@
 /**
- * Return a human readable document size
+ * Return a human-readable document size
  * For example formatSize(7570718) outputs '7.6 MB'
+ * This function uses 1000 for kilo (not 1024)
  * @param size
- * @param kilo Is 1000 by default, you can specify 1024 if you
- *                             want the output in KiB
- * @return Returns a human readable size
+ * @return Returns a human-readable size
  */
-export function formatSize(size: number, kilo = 1000): string {
-  if (size < 0.9 * kilo) {
+export function formatSize(size: number): string {
+  const kilo = 1000
+  const factor = 0.9
+
+  if (size < factor * kilo) {
     return size.toFixed() + ' B'
   }
 
   const KB = size / kilo
-  if (KB < 0.9 * kilo) {
+  if (KB < factor * kilo) {
     return KB.toFixed(1) + ' KB'
   }
 
   const MB = KB / kilo
-  if (MB < 0.9 * kilo) {
+  if (MB < factor * kilo) {
     return MB.toFixed(1) + ' MB'
   }
 
   const GB = MB / kilo
-  if (GB < 0.9 * kilo) {
+  if (GB < factor * kilo) {
     return GB.toFixed(1) + ' GB'
   }
 
