You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.
All objects serialized by the plugin are in the whitelist of this PR or are basic classes already in the Jenkins whitelist, except java.lang.Thread$State. Is it necessary to add java.lang.Thread$State to this PR and to [JENKINS-47736] Switch Remoting/XStream blacklist to a whitelist jenkins#3120 ? (It's a simple enum).
Before 1.68.0 of the monitoring plugin, the same 11 classes were in the net.bull.javamelody package and not in the net.bull.javamelody.internal.model package. According to stats, about 5000 installations are 1.68+ and ok with the current whitelist, so about 6000 installations are not. Perhaps those 6000 installations will not upgrade to the latest Jenkins without upgrading the plugin, but we don't know that. So for those 6000 installations to work with the latest Jenkins, should the same 11 classes be added with the net.bull.javamelody package in the whitelists of [JENKINS-47736] Switch Remoting/XStream blacklist to a whitelist jenkins#3120?
Yes, I ran mock-slave and tried to use all the plugin features I could find on a mock agent until I fixed all the errors.
All objects serialized by the plugin are in the whitelist of this PR or are basic classes already in the Jenkins whitelist
See JEP-200 for details. I believe this PR is all that is needed.
So for those 6000 installations to work with the latest Jenkins, should the same 11 classes be added
You should release this PR and people should just upgrade their plugin if they expect things to work. Anyway if you look at the correlation you will see that the vast majority of people who have updated Jenkins to a weekly release are also using the latest release of this plugin—there are only a handful of people who updated Jenkins but declined to update the plugin. That is the normal situation for most plugins.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jenkinsci/jenkins#3120.
@reviewbybees