You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Java 21 was released Sep 19, 2023. We want to announce full support
for Java 21 in early October and would like the most used plugins to be
compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already
passing with Java 21. This is a further step to improve plugin readiness
for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17
and Java 21 because we believe that the risk of a regression that only
affects Java 11 is low. We generate Java 11 byte code with the Java 17
and the Java 21 builds, so we're already testing Java 11 byte code.
To my understanding, this will also avoid implied dependencies in Jenkins as described in PR #8, which would be awesome!
Can this be merged and released please?
@evernat or @kohsuke would you be willing to merge this pull request so that the plugin is regularly tested with Java 21? No need for a release, just a merge of the change.
@andham an incremental build of the plugin with this change is available. Could you test it and share the results so that others know if it resolves the question you asked earlier in #12 (comment) ?
Thanks @andham and @MarkEWaite
Note that this plugin is not abandoned and I continue to maintain it, like I have done for the last 14 years. Version is synchronized by me with javamelody-core and release is automated with a script which is not here.
PR #11 was on hold following very unpleasant discussion about itext dependency in particular.
I think I am not resentful, so we can put that under the carpet.
Thanks @andham and @MarkEWaite Note that this plugin is not abandoned and I continue to maintain it, like I have done for the last 14 years. Version is synchronized by me with javamelody-core and release is automated with a script which is not here.
Thanks very much for maintaining the plugin! Much appreciated. I wasn't aware that the version number is synchronized with the release of javamelody-core. Considering the multiple plugins that you maintain for java-melody core, that makes sense. It also makes sense that the release script is outside this repository, since there are plugins for multiple systems (Jenkins, Confluence, Bamboo, ...).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test with Java 21
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Includes the pull request:
Testing done
Confirmed that tests pass with Java 21 on Linux.
Submitter checklist