You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request si too short.
Have you tested it? Are services still monitored? Why was this call needed before Grails 3 and why it is not needed anymore?
Why writing grailsVersion=3.2.11 in gradle.properties fixes the issue without this PR?
See also apache/grails-core#10715 (comment)
Applying this fix makes one of my test work (that was not working without the change) that modifies the metaclass of a domain class and uses @ConfineMetaClassChanges annotation.
I'll create a project that reproduces this.
I will now check that the plugin still monitor service with that change.
@evernat I've checked that we have this ExpandoMetaClass.enableGlobally() since the SVN version of the plugin, so it's probably linked with an old version of Groovy... Since Martin tested it I think we can merge it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply fix proposed by graemerocher in grails-core-10715: not a grails-core bug but instead in the plugin; apache/grails-core#10715 (comment)