tls: stop sending ssl_renegotiation_limit in startup message #476

tejasmanohar · 2018-10-30T04:35:49Z

This addresses #321 with the
fix @jackc proposed there--

The only reason we send ssl_renegotiation_limit is to avoid mysterious connection errors when connecting to servers that use renegotiation. But PostgreSQL defaults to 0 for all supported versions, and removed the setting for 9.6. So I guess all we need to do is remove the default startup parameter message. Anyone who really needs it can easily add it back with ConnConfig.RuntimeParams.

Redshift users that need to connect
w/ SSL currently fork the library to delete this parameter, e.g.

segmentio@8e0028d

And, that's annoying to keep up-to-date :)

tejasmanohar · 2018-10-30T04:38:28Z

As expressed in doc.go, I think this fix should go in v3.3.0. While I doubt this breaks connections for many, I suppose it could if a user of this library ignores warnings and has a non-zero value for this parameter set in postgresql.conf in Postgres < 9.6. That said, I don't feel strongly :P

@jackc

This addresses jackc#321 with the fix @jackc proposed there. Redshift users that need to connect w/ SSL currently fork the library to delete this parameter, e.g. segmentio@8e0028d And, that's annoying to keep up-to-date :)

jackc · 2018-11-03T20:04:31Z

Thanks. I agree it is reasonable to make this change in a minor release. It's really hard to imagine a case where it would cause breakage.

tejasmanohar · 2018-11-27T01:05:47Z

@jackc Thanks for merging this. Would you please publish a v3.3.0 tag? Or, are you waiting on something else to do that? The docs change merged in this PR mentions this being available as of v3.30, and I'd like to pin vendor of my project that requires this fix to a release of pgx.

jackc · 2018-12-01T17:14:16Z

Okay, I released v3.3.0.

tejasmanohar · 2018-12-02T02:12:54Z

Appreciate it

tejasmanohar mentioned this pull request Oct 30, 2018

RedShift doesn't support ssl_renegotiation_limit #321

Closed

tejasmanohar force-pushed the remove_tls_renegotiation_msg branch 2 times, most recently from ad95b87 to 36ab648 Compare October 30, 2018 04:45

tls: stop sending ssl_renegotiation_limit in startup message

e2010c8

This addresses jackc#321 with the fix @jackc proposed there. Redshift users that need to connect w/ SSL currently fork the library to delete this parameter, e.g. segmentio@8e0028d And, that's annoying to keep up-to-date :)

tejasmanohar force-pushed the remove_tls_renegotiation_msg branch from 36ab648 to e2010c8 Compare October 30, 2018 04:50

jackc merged commit a76c2eb into jackc:master Nov 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tls: stop sending ssl_renegotiation_limit in startup message #476

tls: stop sending ssl_renegotiation_limit in startup message #476

Uh oh!

tejasmanohar commented Oct 30, 2018 •

edited

Loading

Uh oh!

tejasmanohar commented Oct 30, 2018 •

edited

Loading

Uh oh!

jackc commented Nov 3, 2018

Uh oh!

tejasmanohar commented Nov 27, 2018 •

edited

Loading

Uh oh!

jackc commented Dec 1, 2018

Uh oh!

tejasmanohar commented Dec 2, 2018

Uh oh!

Uh oh!

tls: stop sending ssl_renegotiation_limit in startup message #476

tls: stop sending ssl_renegotiation_limit in startup message #476

Uh oh!

Conversation

tejasmanohar commented Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tejasmanohar commented Oct 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jackc commented Nov 3, 2018

Uh oh!

tejasmanohar commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jackc commented Dec 1, 2018

Uh oh!

tejasmanohar commented Dec 2, 2018

Uh oh!

Uh oh!

tejasmanohar commented Oct 30, 2018 •

edited

Loading

tejasmanohar commented Oct 30, 2018 •

edited

Loading

tejasmanohar commented Nov 27, 2018 •

edited

Loading