isomorphic-git
diff --git a/‎README.md
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎README.md
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎__tests__/__helpers__/generate-docs.js
Copy file name to clipboard
+4-1Lines changed: 4 additions & 1 deletion b/‎__tests__/__helpers__/generate-docs.js
Copy file name to clipboard
+4-1Lines changed: 4 additions & 1 deletion
diff --git a/‎__tests__/test-hosting-providers.js
Copy file name to clipboard
+47-94Lines changed: 47 additions & 94 deletions b/‎__tests__/test-hosting-providers.js
Copy file name to clipboard
+47-94Lines changed: 47 additions & 94 deletions
diff --git a/‎__tests__/test-plugin-http.js
Copy file name to clipboard
-31Lines changed: 0 additions & 31 deletions b/‎__tests__/test-plugin-http.js
Copy file name to clipboard
-31Lines changed: 0 additions & 31 deletions
@@ -36,7 +36,6 @@ The following environments are tested in CI and will continue to be supported un
 
 TODO:
 - [ ] I should probably normalize on timestamps and get rid of the `date` options.
-- [ ] I should probably remove `username`, `password`, `token`, and `oauth2format` and make everyone use `onAuth` callback for that.
 - [ ] Update the Useful Snippets.
 
 ### Big changes
@@ -57,6 +56,7 @@ TODO:
 ### Some function parameters have been removed or replaced:
   - [x] The undocumented parameter aliases `authUsername` and `authPassword` were removed.
   - [x] The `emitter` parameter was removed and replaced with the `onMessage` and `onProgress` callbacks. (Note that `onMessage` emits un-trimmed strings, so you get those `\r`s.)
+  - [x] The `username`, `password`, `token`, and `oauth2format` parameters were removed and replaced with the `onAuth` callback.
   - [x] The `fast` parameter of `pull` was removed, since there is no "slow" implementation anymore.
   - [x] The `signing` parameter of `log` was removed, since `log` will always return a payload.
   - [x] The `pattern` parameter was removed from `statusMatrix` and replaced with a new `filter` function. (This is so we can drop the dependencies on `globalyzer` and `globrex`.)
 
@@ -199,7 +199,10 @@ async function gendoc(file, filepath) {
           let name = param.name.replace('_.', '').replace('args.', '')
           const actualName = name
           const shouldLink =
-            actualName.startsWith('on') || name === 'http' || name === 'fs'
+            actualName.startsWith('on') ||
+            name === 'http' ||
+            name === 'fs' ||
+            name === 'headers'
           if (!param.optional) name = `**${name}**`
 
           let type = param.type.names.map(escapeType).join(' | ')
 
@@ -9,17 +9,21 @@ const { makeFixture } = require('./__helpers__/FixtureFS.js')
 const localhost =
   typeof window === 'undefined' ? 'localhost' : window.location.hostname
 
+const reverse = t =>
+  t
+    .split('')
+    .reverse()
+    .join('')
+
 describe('Hosting Providers', () => {
   describe('AWS CodeCommit', () => {
+    // These HTTPS Git credentials for AWS CodeCommit are for IAM user arn:aws:iam::260687965765:user/tester
+    // which only has git access to the test repo:
+    // https://git-codecommit.us-west-2.amazonaws.com/v1/repos/test.empty
+    // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
+    const password = reverse('=cYfZKeyeW3ig0yZrkzkd9ElDKYctLgV2WNOZ1Ctntnt')
+    const username = 'tester-at-260687965765'
     it('fetch', async () => {
-      // These HTTPS Git credentials for AWS CodeCommit are for IAM user arn:aws:iam::260687965765:user/tester
-      // which only has git access to the test repo:
-      // https://git-codecommit.us-west-2.amazonaws.com/v1/repos/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = '=cYfZKeyeW3ig0yZrkzkd9ElDKYctLgV2WNOZ1Ctntnt'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -28,24 +32,15 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'tester-at-260687965765',
-        password: token,
         remote: 'awscc',
         ref: 'master',
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.defaultBranch).toBe('refs/heads/master')
       expect(res.fetchHead).toBe('c03e131196f43a78888415924bcdcbf3090f3316')
     })
     it('push', async () => {
-      // These HTTPS Git credentials for AWS CodeCommit are for IAM user arn:aws:iam::260687965765:user/tester
-      // which only has git access to the test repo:
-      // https://git-codecommit.us-west-2.amazonaws.com/v1/repos/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = '=cYfZKeyeW3ig0yZrkzkd9ElDKYctLgV2WNOZ1Ctntnt'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -54,25 +49,23 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'tester-at-260687965765',
-        password: token,
         remote: 'awscc',
         ref: 'master',
         force: true,
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.ok).toBe(true)
       expect(res.refs['refs/heads/master'].ok).toBe(true)
     })
   })
+
   describe('Azure DevOps', () => {
+    // These git credentials are specific to https://isomorphic-git@dev.azure.com/isomorphic-git/isomorphic-git/_git/test.empty
+    // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
+    const password = reverse('ez8dMKyRfWpzMkhg3QJb5m')
+    const username = 'isomorphicgittestpush'
     it('fetch', async () => {
-      // These git credentials are specific to https://isomorphic-git@dev.azure.com/isomorphic-git/isomorphic-git/_git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'ez8dMKyRfWpzMkhg3QJb5m'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -81,22 +74,15 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         // corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphicgittestpush',
-        password: token,
         remote: 'azure',
         ref: 'master',
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.defaultBranch).toBe('refs/heads/master')
       expect(res.fetchHead).toBe('c03e131196f43a78888415924bcdcbf3090f3316')
     })
     it('push', async () => {
-      // These git credentials are specific to https://isomorphic-git@dev.azure.com/isomorphic-git/isomorphic-git/_git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'ez8dMKyRfWpzMkhg3QJb5m'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -105,27 +91,25 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         // corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphicgittestpush',
-        password: token,
         remote: 'azure',
         ref: 'master',
         force: true,
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.ok).toBe(true)
       expect(res.refs['refs/heads/master'].ok).toBe(true)
     })
   })
+
   describe('Bitbucket', () => {
+    // This App Password is for the test account 'isomorphic-git' user on Bitbucket,
+    // with "repositories.read" and "repositories.write" access. However the only repo the account has access to is
+    // https://bitbucket.org/isomorphic-git/test.empty
+    // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
+    const password = reverse('TqSWhF3xLxEEXKQtZTwn')
+    const username = 'isomorphic-git'
     it('push', async () => {
-      // This App Password is for the test account 'isomorphic-git' user on Bitbucket,
-      // with "repositories.read" and "repositories.write" access. However the only repo the account has access to is
-      // https://bitbucket.org/isomorphic-git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'TqSWhF3xLxEEXKQtZTwn'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -134,25 +118,16 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphic-git',
-        password: token,
         remote: 'bitbucket',
         ref: 'master',
         force: true,
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.ok).toBe(true)
       expect(res.refs['refs/heads/master'].ok).toBe(true)
     })
     it('fetch', async () => {
-      // This App Password is for the test account 'isomorphic-git' user on Bitbucket,
-      // with "repositories.read" and "repositories.write" access. However the only repo the account has access to is
-      // https://bitbucket.org/isomorphic-git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'TqSWhF3xLxEEXKQtZTwn'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -161,26 +136,23 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphic-git',
-        password: token,
         remote: 'bitbucket',
         ref: 'master',
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.defaultBranch).toBe('refs/heads/master')
       expect(res.fetchHead).toBe('c03e131196f43a78888415924bcdcbf3090f3316')
     })
   })
+
   describe('GitHub', () => {
+    // This Personal OAuth token is for a test account (https://github.com/isomorphic-git-test-push)
+    // with "public_repo" access. The only repo it has write access to is
+    // https://github.com/isomorphic-git/test.empty
+    // It is stored reversed to avoid Github's auto-revoking feature.
+    const token = reverse('e8df25b340c98b7eec57a4976bd9074b93a7dc1c')
     it('fetch', async () => {
-      // This Personal OAuth token is for a test account (https://github.com/isomorphic-git-test-push)
-      // with "public_repo" access. The only repo it has write access to is
-      // https://github.com/isomorphic-git/test.empty
-      // It is stored reversed to avoid Github's auto-revoking feature.
-      const token = 'e8df25b340c98b7eec57a4976bd9074b93a7dc1c'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -189,23 +161,15 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        token: token,
         remote: 'github',
         ref: 'master',
+        onAuth: () => ({ token }),
       })
       expect(res).toBeTruthy()
       expect(res.defaultBranch).toBe('refs/heads/test')
       expect(res.fetchHead).toBe('c03e131196f43a78888415924bcdcbf3090f3316')
     })
     it('push', async () => {
-      // This Personal OAuth token is for a test account (https://github.com/isomorphic-git-test-push)
-      // with "public_repo" access. The only repo it has write access to is
-      // https://github.com/isomorphic-git/test.empty
-      // It is stored reversed to avoid Github's auto-revoking feature.
-      const token = 'e8df25b340c98b7eec57a4976bd9074b93a7dc1c'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -214,26 +178,25 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        token: token,
         remote: 'github',
         ref: 'master',
         force: true,
+        onAuth: () => ({ token }),
       })
       expect(res).toBeTruthy()
       expect(res.ok).toBe(true)
       expect(res.refs['refs/heads/master'].ok).toBe(true)
     })
   })
+
   describe('GitLab', () => {
+    // This Personal Access Token is for a test account (https://gitlab.com/isomorphic-git-test-push)
+    // with "read_repository" and "write_repository" access. However the only repo it has write access to is
+    // https://gitlab.com/isomorphic-git/test.empty
+    // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
+    const password = reverse('vjNzgKP7acS6e6vb2Q6g')
+    const username = 'isomorphic-git-test-push'
     it('fetch', async () => {
-      // This Personal Access Token is for a test account (https://gitlab.com/isomorphic-git-test-push)
-      // with "read_repository" and "write_repository" access. However the only repo it has write access to is
-      // https://gitlab.com/isomorphic-git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'vjNzgKP7acS6e6vb2Q6g'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -242,24 +205,15 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphic-git-test-push',
-        password: token,
         remote: 'gitlab',
         ref: 'master',
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.defaultBranch).toBe('refs/heads/master')
       expect(res.fetchHead).toBe('c03e131196f43a78888415924bcdcbf3090f3316')
     })
     it('push', async () => {
-      // This Personal Access Token is for a test account (https://gitlab.com/isomorphic-git-test-push)
-      // with "read_repository" and "write_repository" access. However the only repo it has write access to is
-      // https://gitlab.com/isomorphic-git/test.empty
-      // It is stored reversed because the GitHub one is stored reversed and I like being consistant.
-      const token = 'vjNzgKP7acS6e6vb2Q6g'
-        .split('')
-        .reverse()
-        .join('')
       // Setup
       const { fs, gitdir } = await makeFixture('test-hosting-providers')
       // Test
@@ -268,11 +222,10 @@ describe('Hosting Providers', () => {
         http,
         gitdir,
         corsProxy: process.browser ? `https://${localhost}:9999` : undefined,
-        username: 'isomorphic-git-test-push',
-        password: token,
         remote: 'gitlab',
         ref: 'master',
         force: true,
+        onAuth: () => ({ username, password }),
       })
       expect(res).toBeTruthy()
       expect(res.ok).toBe(true)