Link buttons[0] and buttons[1] to primary actions #24

Manishearth · 2019-10-22T19:35:50Z

toji

LGTM

NellWaliczek · 2019-10-23T16:28:15Z

index.bs

@@ -209,7 +211,7 @@ This module extends the {{GamepadMappingType}} to describe the mapping of common

 The <dfn enum-value for="GamepadMappingType">xr-standard</dfn> mapping indicates that the layout of the buttons and axes of the {{XRInputSource/gamepad}} corresponds as closely as possible to the tables below.

-In order to report a {{Gamepad/mapping}} of {{GamepadMappingType/"xr-standard"}} the device MUST report a {{XRInputSource/targetRayMode}} of {{XRTargetRayMode/"tracked-pointer"}} and MUST have a non-<code>null</code> {{XRInputSource/gripSpace}}. It MUST have at least one primary button, often a trigger, separate from any touchpads or thumbsticks. If a device does not meet the requirements for the {{GamepadMappingType/"xr-standard"}} mapping it may still expose a {{XRInputSource/gamepad}} with a {{Gamepad/mapping}} of <code>""</code> (empty string). The {{GamepadMappingType/"xr-standard"}} mapping MUST only be used by {{Gamepad}} instances reported by an {{XRInputSource}}.
+In order to report a {{Gamepad/mapping}} of {{GamepadMappingType/"xr-standard"}} the device MUST report a {{XRInputSource/targetRayMode}} of {{XRTargetRayMode/"tracked-pointer"}} and MUST have a non-<code>null</code> {{XRInputSource/gripSpace}}. It MUST have at least one <dfn>primary button</dfn>, often a trigger, separate from any touchpads or thumbsticks. The [=primary button=] MUST trigger the [=primary action=] for the input source. The device MAY have a <dfn>primary squeeze button</dfn>, which MUST trigger the [=primary squeeze action=] for the input source. If a device does not meet the requirements for the {{GamepadMappingType/"xr-standard"}} mapping it may still expose a {{XRInputSource/gamepad}} with a {{Gamepad/mapping}} of <code>""</code> (empty string). The {{GamepadMappingType/"xr-standard"}} mapping MUST only be used by {{Gamepad}} instances reported by an {{XRInputSource}}.


have at least one primary button, often a trigger

In #17 it appears we settled on this needing to be a trigger. Mind fixing that at the same time?

NellWaliczek · 2019-10-23T16:30:11Z

index.bs

@@ -209,7 +211,7 @@ This module extends the {{GamepadMappingType}} to describe the mapping of common

 The <dfn enum-value for="GamepadMappingType">xr-standard</dfn> mapping indicates that the layout of the buttons and axes of the {{XRInputSource/gamepad}} corresponds as closely as possible to the tables below.

-In order to report a {{Gamepad/mapping}} of {{GamepadMappingType/"xr-standard"}} the device MUST report a {{XRInputSource/targetRayMode}} of {{XRTargetRayMode/"tracked-pointer"}} and MUST have a non-<code>null</code> {{XRInputSource/gripSpace}}. It MUST have at least one primary button, often a trigger, separate from any touchpads or thumbsticks. If a device does not meet the requirements for the {{GamepadMappingType/"xr-standard"}} mapping it may still expose a {{XRInputSource/gamepad}} with a {{Gamepad/mapping}} of <code>""</code> (empty string). The {{GamepadMappingType/"xr-standard"}} mapping MUST only be used by {{Gamepad}} instances reported by an {{XRInputSource}}.
+In order to report a {{Gamepad/mapping}} of {{GamepadMappingType/"xr-standard"}} the device MUST report a {{XRInputSource/targetRayMode}} of {{XRTargetRayMode/"tracked-pointer"}} and MUST have a non-<code>null</code> {{XRInputSource/gripSpace}}. It MUST have at least one <dfn>primary button</dfn>, often a trigger, separate from any touchpads or thumbsticks. The [=primary button=] MUST trigger the [=primary action=] for the input source. The device MAY have a <dfn>primary squeeze button</dfn>, which MUST trigger the [=primary squeeze action=] for the input source. If a device does not meet the requirements for the {{GamepadMappingType/"xr-standard"}} mapping it may still expose a {{XRInputSource/gamepad}} with a {{Gamepad/mapping}} of <code>""</code> (empty string). The {{GamepadMappingType/"xr-standard"}} mapping MUST only be used by {{Gamepad}} instances reported by an {{XRInputSource}}.


nit: might be clearer to say?

The device MAY have a primary squeeze button, which, if present, MUST trigger the [=primary squeeze action=] for the input source.

Manishearth · 2019-10-23T18:50:34Z

Addressed

Manishearth · 2019-10-23T18:51:03Z

Actually, there's no need to keep this a draft, as long as folks know this is contingent on immersive-web/webxr#893

NellWaliczek

LGTM!

Link buttons[0] and buttons[1] to primary actions

ef43d32

Manishearth mentioned this pull request Oct 22, 2019

Define squeeze events immersive-web/webxr#893

Merged

toji approved these changes Oct 22, 2019

View reviewed changes

NellWaliczek reviewed Oct 23, 2019

View reviewed changes

Manishearth added 2 commits October 23, 2019 11:50

Primary button -> primary trigger

8988df2

clarify MAY/MUST

cd32c14

Manishearth marked this pull request as ready for review October 23, 2019 18:50

Manishearth added this to the October 2019 milestone Oct 23, 2019

NellWaliczek approved these changes Oct 23, 2019

View reviewed changes

Manishearth mentioned this pull request Oct 23, 2019

Is xr-standard's button 0 meant just for triggers or also for other primary buttons? #17

Closed

Manishearth merged commit 86db6f7 into immersive-web:master Oct 28, 2019

Manishearth deleted the primary-action branch October 28, 2019 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Link buttons[0] and buttons[1] to primary actions #24

Link buttons[0] and buttons[1] to primary actions #24

Uh oh!

Manishearth commented Oct 22, 2019

Uh oh!

toji left a comment

Uh oh!

NellWaliczek Oct 23, 2019

Uh oh!

NellWaliczek Oct 23, 2019

Uh oh!

Manishearth commented Oct 23, 2019

Uh oh!

Manishearth commented Oct 23, 2019

Uh oh!

NellWaliczek left a comment

Uh oh!

Uh oh!

Link buttons[0] and buttons[1] to primary actions #24

Link buttons[0] and buttons[1] to primary actions #24

Uh oh!

Conversation

Manishearth commented Oct 22, 2019

Uh oh!

toji left a comment

Choose a reason for hiding this comment

Uh oh!

NellWaliczek Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

NellWaliczek Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

Manishearth commented Oct 23, 2019

Uh oh!

Manishearth commented Oct 23, 2019

Uh oh!

NellWaliczek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!