Block mid-session consent requests #767

toji · 2019-07-17T16:46:31Z

/fixes #751

Details that consent dialogs may not be displayed while an immersive
session is active, and explains that this is a short-term restriction.

I chose to go with terminating the session in this case rather than
suppressing the consent dialog altogether, since it provides very clear
feedback about the error case and doesn't require us to make up new
behavior for the permissions in question.

/fixes #751 Details that consent dialogs may not be displayed while an immersive session is active, and explains that this is a short-term restriction. I chose to go with terminating the session in this case rather than suppressing the consent dialog altogether, since it provides very clear feedback about the error case and doesn't require us to make up new behavior for the permissions in question.

toji · 2019-07-17T16:50:38Z

Also pinging @blairmacintyre, though I couldn't add you as a reviewer since you haven't been explicitly added as a collaborator for this repo. (We can change that if you'd like!)

blairmacintyre · 2019-07-17T17:07:01Z

index.bs

+
+There are multiple non-XR APIs which cause user agents to request [=explicit consent=] to use a feature. If the user agent will request the user's consent while there is an [=active immersive session=], the user agent MUST [=shut down the session=] prior to displaying the consent request to the user. If the user's consent for the feature had been granted prior to the [=active immersive session=] being created the session does not need to be terminated. 
+
+Note: This limitation is to ensure that there is behavioral parity between all user agents until consensus is reached about how to securely display these types of prompts. It is not expected to be a long term requirement. 


Looks good to me!

LGTM. I particularly appreciate that the motivation is spelled out. Thank you!

blairmacintyre · 2019-07-17T17:07:22Z

Looks good. (And I'm happy to be a collaborator)

index.bs

Co-Authored-By: johnpallett <johnpallett@google.com>

NellWaliczek

Glad we were able to reach consensus on this temporary measure!

toji added this to the June 2019 milestone Jul 17, 2019

toji requested review from kearwood, NellWaliczek and johnpallett July 17, 2019 16:46

blairmacintyre reviewed Jul 17, 2019

View reviewed changes

johnpallett reviewed Jul 17, 2019

View reviewed changes

index.bs Outdated Show resolved Hide resolved

Update index.bs

4114ccc

Co-Authored-By: johnpallett <johnpallett@google.com>

NellWaliczek approved these changes Jul 19, 2019

View reviewed changes

toji merged commit 8eaae9e into master Jul 19, 2019

toji deleted the mid-session-consent branch July 19, 2019 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Block mid-session consent requests #767

Block mid-session consent requests #767

Uh oh!

toji commented Jul 17, 2019

Uh oh!

toji commented Jul 17, 2019

Uh oh!

blairmacintyre Jul 17, 2019

Uh oh!

johnpallett Jul 17, 2019

Uh oh!

blairmacintyre commented Jul 17, 2019

Uh oh!

Uh oh!

NellWaliczek left a comment

Uh oh!

Uh oh!


		There are multiple non-XR APIs which cause user agents to request [=explicit consent=] to use a feature. If the user agent will request the user's consent while there is an [=active immersive session=], the user agent MUST [=shut down the session=] prior to displaying the consent request to the user. If the user's consent for the feature had been granted prior to the [=active immersive session=] being created the session does not need to be terminated.

		Note: This limitation is to ensure that there is behavioral parity between all user agents until consensus is reached about how to securely display these types of prompts. It is not expected to be a long term requirement.

Block mid-session consent requests #767

Block mid-session consent requests #767

Uh oh!

Conversation

toji commented Jul 17, 2019

Uh oh!

toji commented Jul 17, 2019

Uh oh!

blairmacintyre Jul 17, 2019

Choose a reason for hiding this comment

Uh oh!

johnpallett Jul 17, 2019

Choose a reason for hiding this comment

Uh oh!

blairmacintyre commented Jul 17, 2019

Uh oh!

Uh oh!

NellWaliczek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!