Edit requestSession() and Initialize the session #601

jungkees · 2019-04-22T22:02:58Z

This change fixes strings to the XRSessionMode values, uses the same format for
DOMExceptions, and makes the Initialize the session algorithm more explicit by
defining parameters to it. This does not have any behavioral change.

This change fixes strings to the XRSessionMode values, uses the same format for DOMExceptions, and makes the Initialize the session algorithm more explicit by defining parameters to it. This does not have any behavioral change.

Manishearth

Yeah, most other specs very carefully separate attributes ({{XRSession/mode}}) from the internal parameters (|mode|) they reflect, I was surprised that this wasn't being done here. I definitely support moving closer towards this model for this spec, it's much easier to evolve spec-wise.

toji · 2019-04-23T00:16:55Z

Thank you very much.

jungkees · 2019-04-23T00:18:40Z

Thanks for reviewing and merging this!

Edit requestSession() and Initialize the session

2298de1

This change fixes strings to the XRSessionMode values, uses the same format for DOMExceptions, and makes the Initialize the session algorithm more explicit by defining parameters to it. This does not have any behavioral change.

Manishearth approved these changes Apr 22, 2019

View reviewed changes

toji merged commit 15f0ef6 into immersive-web:master Apr 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Edit requestSession() and Initialize the session #601

Edit requestSession() and Initialize the session #601

Uh oh!

jungkees commented Apr 22, 2019

Uh oh!

Manishearth left a comment

Uh oh!

toji commented Apr 23, 2019

Uh oh!

jungkees commented Apr 23, 2019

Uh oh!

Uh oh!

Edit requestSession() and Initialize the session #601

Edit requestSession() and Initialize the session #601

Uh oh!

Conversation

jungkees commented Apr 22, 2019

Uh oh!

Manishearth left a comment

Choose a reason for hiding this comment

Uh oh!

toji commented Apr 23, 2019

Uh oh!

jungkees commented Apr 23, 2019

Uh oh!

Uh oh!