| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 16 Jul 2025 20:10:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=352.564469,conversation_content-fragment;desc="conversation_content fragment";dur=885.546715,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=304.092907,nginx;desc="NGINX";dur=0.84835,glb;desc="GLB";dur=95.313329
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=a9vGFMjJJUMBPclXYPC3ZMNNozRdoG7baqmGblZuNVZCUg%2BCLVOXbqmM8RxvUfxwMjLFWDmm9Qr6cYQtRqej18YdMHH2UkA47AkR8ysUIynSja6jk3lWMw6NgUE2c9zxEStea3niF4agPri5xaFbQ67pB4OPB7UdrDqi2nXE09QtKDB79MmdSX9RRpDfvV5Ca8llAWsAkJgBybxcrprGz%2F427d%2FDU0fEKAt35yRGbKJoGWzKgC9BX1%2BZzwkuqXYEo48pV2otgMbmQa%2FCAuB7zQ%3D%3D--KDm1U16%2BZmJubisk--iHAY2RP0HLg3yvF1bgYEPw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1731410429.1752696641; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 20:10:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 20:10:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C068:2C5932:5F34B:7EBAC:68780741
Remove attribs that only reflect requested values by toji · Pull Request #574 · immersive-web/webxr · GitHub
toji
changed the title
Remove attribs that only reflect requested values and condense reference space interfaces
Remove attribs that only reflect requested values
Apr 12, 2019
toji
added
the
potential breaking change
Issues that may affect the core design structure.
label
Apr 17, 2019
AdaRoseCannon
added
ed:explainer
Include in newsletter, explainer change
ed:spec
Include in newsletter, spec change
labels
May 8, 2019
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 401
Remove attribs that only reflect requested values #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nell requested that I split out the attribs and reference space bits of this PR, which I'm fine with. I'll get to that sometime in the next week or so. |
toji
changed the title
|
Separated changes as requested. Reference space consolidation is now handled in #587. |
NellWaliczek
suggested changes
Apr 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback... I'm generally supportive of this change
|
Feedback addressed. Take one more look? |
toji
added
the
potential breaking change
|
Rebased. Review ping, @NellWaliczek? |
NellWaliczek
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure the final commit title reflects which types we actually cleaned up, but other than that LGTM!
AdaRoseCannon
added
ed:explainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ed:explainer
Include in newsletter, explainer change
ed:spec
Include in newsletter, spec change
potential breaking change
Issues that may affect the core design structure.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #513
Addresses some discussion in #514, but doesn't change the enums.
This PR removes the
modeattrib fromXRSession, thedepth,stencil, andalphaattribs fromXRWebGLLayer, and thesubtypeattrib fromXRStationaryReferenceSpace. Since that leftXRStationaryReferenceSpacewith nothing else in it, I also took the opportunity to consolidate it andXRUnboundedReferenceSpaceintoXRReferenceSpace.