You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Your PR description mentions not including the originOffset changes in this PR. Are you planning to update getPose() and getViewerPose() as part of that change rather than this one?
The reason will be displayed to describe this comment to others. Learn more.
We don't really need to, in my opinion. If you passed in any other non-applicable values in the dictionary (ie: { type: 'identity', foo: 'bar' }) then we just ignore it, so that feels like it could carry over to this as well? Then again, if you passed a subtype that wasn't valid the IDL would cause it to naturally error whether or not the type uses it, so maybe being more rigorous about it isn't a bad idea? IDK.
The reason will be displayed to describe this comment to others. Learn more.
My general opinion is that we should do what's consistent with the rest of the web on this one. Got an API ergonomics person who wants to give us guidance one way or another?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482
Adding the
"identity"
reference space type. Not includingoriginOffset
at this point to keep PRs focused and easy to review.