You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum viewport scale must ensure that the viewport has a nonzero
size, and this may in theory require an adjustment if the session's
baseLayer is changed during a session to use a very small
framebufferScaleFactor.
Change the wording to clarify that it's not necessarily constant for an
entire session.
The minimum viewport scale must ensure that the viewport has a nonzero
size, and this may in theory require an adjustment if the session's
baseLayer is changed during a session to use a very small
framebufferScaleFactor.
Change the wording to clarify that it's not necessarily constant for an
entire session.
On second thought, I think it would be easier to enforce the nonzero size
in getViewport, then this change isn't needed and there's less ambiguity
about baseLayer changes.
On second thought, I think it would be easier to enforce the nonzero size in getViewport, then this change isn't needed and there's less ambiguity about baseLayer changes.
Yes, you can update getViewPort to make that adjustment.
Are there UA that require a certain minimum size for the viewport? If so, you could make the adjustment in that function as well.
On second thought, I think it would be easier to enforce the nonzero size in getViewport, then this change isn't needed and there's less ambiguity about baseLayer changes.
Yes, you can update getViewPort to make that adjustment.
I've moved the logic there.
Are there UA that require a certain minimum size for the viewport? If so, you could make the adjustment in that function as well.
I'm not aware of a specific UA requirement (beyond ensuring nonzero size), but I added an optional adjustment there where the UA could clamp to a minimum viewport scale.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum viewport scale must ensure that the viewport has a nonzero
size, and this may in theory require an adjustment if the session's
baseLayer is changed during a session to use a very small
framebufferScaleFactor.
Change the wording to clarify that it's not necessarily constant for an
entire session.
Preview | Diff