You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #961, this is not the only way to fix this issue; the other way to fix it involves changing the spec so that inputSources can start off non-null, however that involves ensuring the ecosystem respects that as well.
The reason will be displayed to describe this comment to others. Learn more.
It's the other way around, resolve uses a microtask, and queue a task uses a regular task, so we can guarantee that the callback attached in requestSession(..).resolve(callback) will execute before the task below does.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #961
As mentioned in #961, this is not the only way to fix this issue; the other way to fix it involves changing the spec so that
inputSources
can start off non-null, however that involves ensuring the ecosystem respects that as well.r? @toji
cc @cabanier