CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 23:55:05 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
etag: W/"571b8b3e6df6db680d8d66c9498b06fe"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XvweesdSITuazzxcoFtdgXMtoQAIAaJZuIDXbh7f62sXRWJHIldTzI0lRUaAdCtDN21KBQCe5wGoakf13US1HLr%2FS%2B%2BcorKYlsPddUsMVtNlIL586nG4mB9MYRwAz1XMBwAz9CP%2BysEAm9TJDw5WUMX0FKunXtC1RREzcdo%2FDDWCCi210q9kti%2BFtr72khwBLhQZNntM5N7Kcy%2FJSWDQMXt1IG%2F1RVLhv0eYxbR7DcqlmTCV6xECuYpZOPMrGZBPXKXnYSjcMseqhMHOATvqVQ%3D%3D--cbHoZivXMWkYdHer--pU8%2FbVU4whzqU5ItYkeBlg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.54739108.1753660505; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 23:55:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 23:55:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CBA4:22FFCB:44089F:5AAA24:6886BC59
08. Reviewing pull requests · iluwatar/java-design-patterns Wiki · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
08. Reviewing pull requests
Ilkka Seppälä edited this page Jan 12, 2025
·
29 revisions
Reviewing incoming pull requests is an open process where anyone can participate and give improvement suggestions. That being said, accepting a pull request can be done by a core team member. The general guidelines for code review are given below.
As a reviewer, you need to follow these steps
- Assign the pull request to yourself
- If the issue is not mentioned in the pull request, mention it. That way it's easy to later link back to the PR.
- Check that the code compiles and the existing tests succeed (CI build does this)
- Does the example code implement the pattern correctly and follow good coding practices?
- Does the example code have proper tests and enough test coverage?
- Is the example code commented well enough, including a general pattern/example description in
App.java
? - Is the YAML front matter on the top of the pattern's
README.md
implemented correctly so the pattern will show correctly on the website? - Are the categories and tags set correctly in the pattern's
README.md
? - Is the pattern well enough described in
README.md
? - Based on the checks above use the GitHub's review functionality to signal your acceptance/rejecting.
- Please add one of the tags mentioned below (type label) as the prefix before squashing and merging the code to the repository.
Prefix | Purpose |
---|---|
feat: |
Adding a new feature. |
bug: |
Fixing a bug. |
refactor: |
Code changes that neither fix a bug nor add a feature (e.g., restructuring). |
style: |
Changes that do not affect the meaning of the code (e.g., formatting, linting). |
test: |
Adding or modifying tests. |
doc: |
Documentation-only changes (e.g., README updates). |
chore: |
Maintenance changes (e.g., build process, tooling, dependency updates). |
perf: |
Performance improvements. |
ci: |
Changes related to continuous integration (e.g., GitHub Actions, pipelines). |
hotfix: |
Urgent bug fixes that require immediate deployment. |
security: |
Security-related changes (e.g., fixing vulnerabilities). |
config: |
Configuration changes (e.g., .env , .gitignore , etc.). |
build: |
Changes related to the build system (e.g., upgrading dependencies). |
deps: |
Adding, removing, or updating dependencies. |
release: |
Version bumps or release-specific changes. |
i18n: |
Internationalization or localization updates. |
ux: |
User experience improvements (e.g., UI changes). |
wip: |
Work in progress. Commit is incomplete but pushed for collaboration. |
revert: |
Reverting a previous commit. |
prototype: |
Experimental or proof-of-concept code. |
analytics: |
Adding or updating analytics or metrics. |
deps-dev: |
Development-only dependency updates. |
- When the pull request is merged, set the milestone (e.g. we are working on 1.23-snapshot -> set the milestone to 1.23)
- Check the affected issues and close them where necessary. Also to the closed issues set the milestone as described above.
- Finally, recognize the contributors if they are not already listed. See Recognizing contributors.
As a general guideline, pull requests with no activity during the last few months will be closed.
You can’t perform that action at this time.