Support keyboard shortcut to open popup panel

gorhill · gorhill · commit e2fdc1b94bee · 2019-11-09T09:53:31.000-05:00
Related discussion: - https://www.reddit.com/r/uBlockOrigin/comments/dt47s0/
diff --git a/platform/firefox/manifest.json b/platform/firefox/manifest.json
@@ -19,6 +19,8 @@
     }
   },
   "commands": {
+    "_execute_browser_action": {
+    },
     "launch-element-zapper": {
       "description": "__MSG_popupTipZapper__"
     },
diff --git a/src/js/shortcuts.js b/src/js/shortcuts.js
@@ -204,7 +204,12 @@
         const template = document.querySelector('#templates .commandEntry');
         const tbody = document.querySelector('.commandEntries tbody');
         for ( const command of commands ) {
-            if ( command.description === '' ) { continue; }
+            if (
+                typeof command.description !== 'string' ||
+                command.description === '' )
+            {
+                continue;
+            }
             const tr = template.cloneNode(true);
             tr.setAttribute('data-name', command.name);
             tr.querySelector('.commandDesc').textContent = command.description;

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@`
`19`	`19`	`}`
`20`	`20`	`},`
`21`	`21`	`"commands": {`
	`22`	`+ "_execute_browser_action": {`
	`23`	`+ },`
`22`	`24`	`"launch-element-zapper": {`
`23`	`25`	`"description": "__MSG_popupTipZapper__"`
`24`	`26`	`},`