Fix deserialization of ArrayBuffer shared by multiple TypedArrays

gorhill · gorhill · commit c92a5182185b · 2024-12-26T19:14:20.000-05:00
Deserialization failed to restore proper ArrayBuffer when used by
multiple TypedArrays.

This didn't affect uBO since this specific code path was never
taken.
diff --git a/src/js/s14e-serializer.js b/src/js/s14e-serializer.js
@@ -851,10 +851,11 @@ const _deserialize = ( ) => {
     case I_DATAVIEW: {
         const byteOffset = deserializeLargeUint();
         const length = deserializeLargeUint();
+        const ref = refCounter++;
         const arrayBuffer = _deserialize();
         const ctor = toArrayBufferViewConstructor[`${type}`];
         const out = new ctor(arrayBuffer, byteOffset, length);
-        readRefs.set(refCounter++, out);
+        readRefs.set(ref, out);
         return out;
     }
     default:
