Fix images not properly downloading on click

gorhill · gorhill · commit aec0bd39e3a7 · 2024-09-26T13:27:06.000-04:00
Related feedback: uBlockOrigin/uBlock-issues#1670 (comment) The issue affected images supporting `srcset` attribute without the presence of `src` attribute. This commit takes add fallback onto `srcset` attribute when the `src` attribute is not present.
diff --git a/src/js/scriptlets/load-large-media-interactive.js b/src/js/scriptlets/load-large-media-interactive.js
@@ -19,10 +19,6 @@
     Home: https://github.com/gorhill/uBlock
 */
 
-'use strict';
-
-/******************************************************************************/
-
 (( ) => {
 
 /******************************************************************************/
@@ -132,30 +128,34 @@ if ( vAPI.largeMediaElementStyleSheet === undefined ) {
 
 const loadMedia = async function(elem) {
     const src = elem.getAttribute('src') || '';
+    if ( src === '' ) { return; }
     elem.removeAttribute('src');
-
     await vAPI.messaging.send('scriptlets', {
         what: 'temporarilyAllowLargeMediaElement',
     });
-
-    if ( src !== '' ) {
-        elem.setAttribute('src', src);
-    }
+    elem.setAttribute('src', src);
     elem.load();
 };
 
 /******************************************************************************/
 
 const loadImage = async function(elem) {
     const src = elem.getAttribute('src') || '';
-    elem.removeAttribute('src');
-
+    const srcset = src === '' && elem.getAttribute('srcset') || '';
+    if ( src === '' && srcset === '' ) { return; }
+    if ( src !== '' ) {
+        elem.removeAttribute('src');
+    }
+    if ( srcset !== '' ) {
+        elem.removeAttribute('srcset');
+    }
     await vAPI.messaging.send('scriptlets', {
         what: 'temporarilyAllowLargeMediaElement',
     });
-
     if ( src !== '' ) {
         elem.setAttribute('src', src);
+    } else if ( srcset !== '' ) {
+        elem.setAttribute('srcset', srcset);
     }
 };
 
