fix: update TableInsertRows.java (#2999)

baeminbo · gcf-owl-bot[bot] · web-flow · commit ff4a086f0aa3 · 2023-11-28T12:52:21.000-05:00
* fix: update TableInsertRows.java Make the example set row id in `addRow`. If row id is missed, it disable the retry b/280865468, which I believe an unexpected behavior to users. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/README.md b/README.md
@@ -53,7 +53,7 @@ If you are using Maven without the BOM, add this to your dependencies:
 If you are using Gradle 5.x or later, add this to your dependencies:
 
 ```Groovy
-implementation platform('com.google.cloud:libraries-bom:26.26.0')
+implementation platform('com.google.cloud:libraries-bom:26.27.0')
 
 implementation 'com.google.cloud:google-cloud-bigquery'
 ```
diff --git a/samples/snippets/src/main/java/com/example/bigquery/TableInsertRows.java b/samples/snippets/src/main/java/com/example/bigquery/TableInsertRows.java
@@ -39,12 +39,13 @@ public static void main(String[] args) {
     Map<String, Object> rowContent = new HashMap<>();
     rowContent.put("booleanField", true);
     rowContent.put("numericField", "3.14");
-
-    tableInsertRows(datasetName, tableName, rowContent);
+    // TODO(developer): Replace the row id with a unique value for each row.
+    String rowId = "ROW_ID";
+    tableInsertRows(datasetName, tableName, rowId, rowContent);
   }
 
   public static void tableInsertRows(
-      String datasetName, String tableName, Map<String, Object> rowContent) {
+      String datasetName, String tableName, String rowId, Map<String, Object> rowContent) {
     try {
       // Initialize client that will be used to send requests. This client only needs to be created
       // once, and can be reused for multiple requests.
@@ -58,9 +59,8 @@ public static void tableInsertRows(
           bigquery.insertAll(
               InsertAllRequest.newBuilder(tableId)
                   // More rows can be added in the same RPC by invoking .addRow() on the builder.
-                  // You can also supply optional unique row keys to support de-duplication
-                  // scenarios.
-                  .addRow(rowContent)
+                  // You can omit the unique row ids to disable de-duplication.
+                  .addRow(rowId, rowContent)
                   .build());
 
       if (response.hasErrors()) {
diff --git a/samples/snippets/src/main/java/com/example/bigquery/TableInsertRowsWithoutRowIds.java b/samples/snippets/src/main/java/com/example/bigquery/TableInsertRowsWithoutRowIds.java
@@ -54,6 +54,8 @@ public static void tableInsertRowsWithoutRowIds(String datasetName, String table
       InsertAllResponse response =
           bigquery.insertAll(
               InsertAllRequest.newBuilder(TableId.of(datasetName, tableName))
+                  // No row ids disable de-duplication, and also disable the retries in the Java
+                  // library.
                   .setRows(
                       ImmutableList.of(
                           InsertAllRequest.RowToInsert.of(rowContent1),
diff --git a/samples/snippets/src/test/java/com/example/bigquery/TableInsertRowsIT.java b/samples/snippets/src/test/java/com/example/bigquery/TableInsertRowsIT.java
@@ -88,8 +88,9 @@ public void testTableInsertRows() {
     Map<String, Object> rowContent = new HashMap<>();
     rowContent.put("booleanField", true);
     rowContent.put("numericField", "3.14");
+    String rowId = "ROW_ID";
     // Testing
-    TableInsertRows.tableInsertRows(BIGQUERY_DATASET_NAME, tableName, rowContent);
+    TableInsertRows.tableInsertRows(BIGQUERY_DATASET_NAME, tableName, rowId, rowContent);
     assertThat(bout.toString()).contains("Rows successfully inserted into table");
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,9 @@ public void testTableInsertRows() {`
`88`	`88`	`Map<String, Object> rowContent = new HashMap<>();`
`89`	`89`	`rowContent.put("booleanField", true);`
`90`	`90`	`rowContent.put("numericField", "3.14");`
	`91`	`+ String rowId = "ROW_ID";`
`91`	`92`	`// Testing`
`92`		`- TableInsertRows.tableInsertRows(BIGQUERY_DATASET_NAME, tableName, rowContent);`
	`93`	`+ TableInsertRows.tableInsertRows(BIGQUERY_DATASET_NAME, tableName, rowId, rowContent);`
`93`	`94`	`assertThat(bout.toString()).contains("Rows successfully inserted into table");`
`94`	`95`	`}`
`95`	`96`	`}`