refactor: replace route.path with route.name

pedrolamas · pedrolamas · commit f71d4b09124c · 2025-02-17T16:10:30.000Z
Signed-off-by: Pedro Lamas &lt;pedrolamas@gmail.com&gt;
diff --git a/src/App.vue b/src/App.vue
@@ -54,7 +54,7 @@
             (socketConnected && apiConnected) &&
               (!klippyReady || hasWarnings) &&
               !inLayout &&
-              $route.path !== '/login'
+              $route.name !== 'login'
           "
         >
           <v-col>
diff --git a/src/components/layout/AppBar.vue b/src/components/layout/AppBar.vue
@@ -329,23 +329,20 @@ export default class AppBar extends Mixins(StateMixin, ServicesMixin, FilesMixin
   }
 
   get isDashboard () {
-    return this.$route.path === '/'
+    return this.$route.name === 'home'
   }
 
   handleResetLayout () {
-    const pathLayouts: Record<string, string> = {
-      '/diagnostics': 'diagnostics'
-    }
-
-    const pathLayout = pathLayouts[this.$route.path]
-    let layoutDefaultState
-    if (pathLayout) {
-      // reset to default init state
-      layoutDefaultState = defaultState().layouts[pathLayout]
-    } else {
-      // reset dashboard to default layout
-      layoutDefaultState = this.$store.getters['layout/getLayout']('dashboard')
-    }
+    const pathLayouts = [
+      'diagnostics'
+    ]
+
+    const pathLayout = pathLayouts.includes(this.$route.name ?? '')
+      ? this.$route.name
+      : undefined
+    const layoutDefaultState = pathLayout
+      ? defaultState().layouts[pathLayout]
+      : this.$store.getters['layout/getLayout']('dashboard')
 
     const toReset = pathLayout ?? this.$store.getters['layout/getSpecificLayoutName']
 
diff --git a/src/components/ui/AppNavItem.vue b/src/components/ui/AppNavItem.vue
@@ -77,7 +77,7 @@ export default class AppNavItem extends Mixins(StateMixin, BrowserMixin) {
     if (
       shortcut === this.accelerator &&
       !eventTargetIsContentEditable(event) &&
-      this.$router.currentRoute.name !== this.to
+      this.$route.name !== this.to
     ) {
       event.preventDefault()
 
diff --git a/src/components/widgets/filesystem/FileSystem.vue b/src/components/widgets/filesystem/FileSystem.vue
@@ -785,7 +785,7 @@ export default class FileSystem extends Mixins(StateMixin, FilesMixin, ServicesM
       if (!gcode) return
 
       if (
-        this.$router.currentRoute.name !== 'home' ||
+        this.$route.name !== 'home' ||
         !this.$store.getters['layout/isEnabledInCurrentLayout']('gcode-preview-card')
       ) {
         this.$router.push({ name: 'gcode_preview' })
@@ -866,7 +866,7 @@ export default class FileSystem extends Mixins(StateMixin, FilesMixin, ServicesM
     SocketActions.printerPrintStart(filename)
 
     // If we aren't on the dashboard, push the user back there.
-    if (this.$router.currentRoute.name !== 'home') {
+    if (this.$route.name !== 'home') {
       this.$router.push({ name: 'home' })
     }
   }
diff --git a/src/components/widgets/spoolman/SpoolSelectionDialog.vue b/src/components/widgets/spoolman/SpoolSelectionDialog.vue
@@ -516,7 +516,7 @@ export default class SpoolSelectionDialog extends Mixins(StateMixin, BrowserMixi
     if (this.filename) {
       await SocketActions.printerPrintStart(this.filename)
 
-      if (this.$router.currentRoute.name !== 'home') {
+      if (this.$route.name !== 'home') {
         this.$router.push({ name: 'home' })
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@`
`54`	`54`	`(socketConnected && apiConnected) &&`
`55`	`55`	`(!klippyReady \|\| hasWarnings) &&`
`56`	`56`	`!inLayout &&`
`57`		`- $route.path !== '/login'`
	`57`	`+ $route.name !== 'login'`
`58`	`58`	`"`
`59`	`59`	`>`
`60`	`60`	`<v-col>`
Original file line number	Diff line number	Diff line change
`@@ -516,7 +516,7 @@ export default class SpoolSelectionDialog extends Mixins(StateMixin, BrowserMixi`
`516`	`516`	`if (this.filename) {`
`517`	`517`	`await SocketActions.printerPrintStart(this.filename)`
`518`	`518`
`519`		`- if (this.$router.currentRoute.name !== 'home') {`
	`519`	`+ if (this.$route.name !== 'home') {`
`520`	`520`	`this.$router.push({ name: 'home' })`
`521`	`521`	`}`
`522`	`522`	`}`