CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:38:48 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
etag: W/"0676996f68c7069062fdf18d48ce4ced"
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1ootvnRAaqwvi3gQsoq9Wh8zdc8Fqq1oBSvVTEtz4AXz97RK3sa%2FNfYdcZoTubVQzuI4h3QajqKYDyCaSu5U%2BhpkYEDJVGZ59KfRt89BOZFYZy57s3XMet0SXy7DOiX6W6VSy5Xkp60Q5BN9YsZ%2BMGX%2FtEYEJXRIWzwsO05mJ2k9PlLh9nLs4IfRKbdMGhxIS0y2kqnTH4SB%2BCoCgU59ZLbD%2BkfZFEe31fiKM2p4i%2F8Njt1HE8jtGzazHIpAP7VjaBLlzLzfgHsQvcQIYZKGWw%3D%3D--SmvuXsLLS3vccG%2BI--11NgOVVnD82rzwpO0134Ng%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1846904562.1753303127; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:38:47 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:38:47 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E14:256CA9:109FAEC:13C6902:68814857
Add CLI params for disabling deleting and config/policy/cors updates by orm-forks · Pull Request #28 · fernando-mc/serverless-finch · GitHub
Show file tree
Hide file tree
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 71
Add CLI params for disabling deleting and config/policy/cors updates #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ class Client { | |
this.serverless = serverless; | ||
this.provider = 'aws'; | ||
this.aws = this.serverless.getProvider(this.provider); | ||
this.options = options; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove the tabs and add in spaces everywhere? You can review in GitHub to compare the spacing here. |
||
|
||
this.commands = { | ||
client: { | ||
|
@@ -102,7 +103,7 @@ class Client { | |
} | ||
|
||
deleteObjectsFromBucket(data) { | ||
if (!this.bucketExists) return BbPromise.resolve(); | ||
if (!this.bucketExists || this.options['delete-contents'] === false) return BbPromise.resolve(); | ||
|
||
this.serverless.cli.log(`Deleting all objects from bucket ${this.bucketName}...`); | ||
|
||
|
@@ -184,6 +185,11 @@ class Client { | |
} | ||
|
||
function configureBucket() { | ||
if (this.options['config-change'] === false) { | ||
this.serverless.cli.log(`Retaining existing bucket configuration for ${this.bucketName}...`); | ||
return BbPromise.resolve(); | ||
} | ||
|
||
this.serverless.cli.log(`Configuring website bucket ${this.bucketName}...`); | ||
|
||
const indexDoc = this.serverless.service.custom.client.indexDocument || 'index.html' | ||
|
@@ -201,6 +207,11 @@ class Client { | |
} | ||
|
||
function configurePolicyForBucket(){ | ||
if (this.options['policy-change'] === false) { | ||
this.serverless.cli.log(`Retaining existing bucket policy for ${this.bucketName}...`); | ||
return BbPromise.resolve(); | ||
} | ||
|
||
this.serverless.cli.log(`Configuring policy for bucket ${this.bucketName}...`); | ||
|
||
let policy = { | ||
|
@@ -228,6 +239,11 @@ class Client { | |
} | ||
|
||
function configureCorsForBucket(){ | ||
if (this.options['cors-change'] === false) { | ||
this.serverless.cli.log(`Retaining existing CORS policy for ${this.bucketName}...`); | ||
return BbPromise.resolve(); | ||
} | ||
|
||
this.serverless.cli.log(`Configuring CORS policy for bucket ${this.bucketName}...`); | ||
|
||
let putPostDeleteRule = { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the
no
in all the flags get removed somewhere?These options make sense to me. Just have to figure out how to refactor some of the documentation to explain these options. And also decide if these make sense as command line args or as config details in serverless.yml.