Fixing a bug that prevents opacity gradient calculation if no other gradients are required.

classner · facebook-github-bot · commit fa44a05567ea · 2021-07-10T01:06:56.000-07:00
Summary: An early-return test for gradient calculation did not include the opacity gradient calculation - hence would also return early without calculating gradients even if opacity gradients are required.

Reviewed By: bottler

Differential Revision: D29505684

fbshipit-source-id: 575e820b8f58b19476b2fe3288702806733e840b
diff --git a/pytorch3d/csrc/pulsar/pytorch/renderer.cpp b/pytorch3d/csrc/pulsar/pytorch/renderer.cpp
@@ -1046,7 +1046,7 @@ Renderer::backward(
       at::optional<torch::Tensor>,
       at::optional<torch::Tensor>>
       ret;
-  if (mode == 1 || (!dif_pos && !dif_col && !dif_rad && !dif_cam)) {
+  if (mode == 1 || (!dif_pos && !dif_col && !dif_rad && !dif_cam && !dif_opy)) {
     return ret;
   }
   // Create the camera information.

Original file line number	Diff line number	Diff line change
`@@ -1046,7 +1046,7 @@ Renderer::backward(`
`1046`	`1046`	`at::optional<torch::Tensor>,`
`1047`	`1047`	`at::optional<torch::Tensor>>`
`1048`	`1048`	`ret;`
`1049`		`- if (mode == 1 \|\| (!dif_pos && !dif_col && !dif_rad && !dif_cam)) {`
	`1049`	`+ if (mode == 1 \|\| (!dif_pos && !dif_col && !dif_rad && !dif_cam && !dif_opy)) {`
`1050`	`1050`	`return ret;`
`1051`	`1051`	`}`
`1052`	`1052`	`// Create the camera information.`