Flexible #channels in TexturesUV.join_scene

bottler · facebook-github-bot · commit 2a0660baabc8 · 2021-06-22T16:07:47.000-07:00
Summary: The TexturesUV class supports an arbitrary number of channels. In one place in join_scene we unnecessarily assumed the usual value, 3.

Reviewed By: patricklabatut

Differential Revision: D29133477

fbshipit-source-id: de8eb15fdd55675da084634d9d99e2a3f4d35401
diff --git a/pytorch3d/renderer/mesh/textures.py b/pytorch3d/renderer/mesh/textures.py
@@ -1121,8 +1121,9 @@ def join_scene(self) -> "TexturesUV":
                 )
             )
         merging_plan = pack_unique_rectangles(heights_and_widths)
+        C = maps[0].shape[-1]
         # pyre-fixme[16]: `Tensor` has no attribute `new_zeros`.
-        single_map = maps[0].new_zeros((*merging_plan.total_size, 3))
+        single_map = maps[0].new_zeros((*merging_plan.total_size, C))
         verts_uvs = self.verts_uvs_list()
         verts_uvs_merged = []
 

Original file line number	Diff line number	Diff line change
`@@ -1121,8 +1121,9 @@ def join_scene(self) -> "TexturesUV":`
`1121`	`1121`	`)`
`1122`	`1122`	`)`
`1123`	`1123`	`merging_plan = pack_unique_rectangles(heights_and_widths)`
	`1124`	`+ C = maps[0].shape[-1]`
`1124`	`1125`	# pyre-fixme[16]: `Tensor` has no attribute `new_zeros`.
`1125`		`- single_map = maps[0].new_zeros((*merging_plan.total_size, 3))`
	`1126`	`+ single_map = maps[0].new_zeros((*merging_plan.total_size, C))`
`1126`	`1127`	`verts_uvs = self.verts_uvs_list()`
`1127`	`1128`	`verts_uvs_merged = []`
`1128`	`1129`