You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed an icon for ep_comments_page that was not on the FontAwesome subset provided by Etherpad, so I added it using Fontello and the existing config.json on the project.
I tried to update this all locally and ended up my browser console crowing about missing font-awesome, and the ep_comments as icons doesn't seem to work at all, even with the JSON clause in my settings. I thought I'd pull down fresh, before I made mention, but even after that I'm having the same issue.
Two things you'll need to do at this moment to make sure icons will work:
Use the latest version of develop branch of Etherpad, not a stable
version (this is because comment icon was merged yesterday to the code,
there's no stable version of it yet);
Use "minify":false on your settings (apparently minifying makes plugins
not able to find fonts on the correct folder).
#1 should be unnecessary when we have a new stable version of Etherpad
released; #2 is a bug and still need to be fixed.
Just as a side note: #2 is necessary even if you don't configure
ep_comments to use icons, otherwise the "delete" icon will not be displayed
correctly. Try to delete a sidebar comment, and you'll get the same 404
error message about fontawesome not found on your console. At least on my
environment I saw that happening.
Hope this helps.
On Friday, June 12, 2015, DrHuxtable <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
I tried to update this all locally and ended up my browser console crowing
about missing font-awesome, and the ep_comments as icons doesn't seem to
work at all, even with the JSON clause in my settings. I thought I'd pull
down fresh, before I made mention, but even after that I'm having the same
issue.
@JohnMcLear,@lpagliari: Thank you both. I'll update to the latest dev branch in an effort to help me run the comments-as-icons feature (and use bin/cleanRun.sh in conjunction), and I'll try temp adding a softlink '/font -> /static/font' locally to see if that will suffice for now on the icon front, as clearing my cache during my previous trials did not help. The last time I disabled minify, I could actually see the performance lags, so that's going to be my last ditch effort. Thanks again. I love the plugin, and I really like this comment icon idea and can't wait to get it folded into my setup.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed an icon for ep_comments_page that was not on the FontAwesome subset provided by Etherpad, so I added it using Fontello and the existing
config.json
on the project.