| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 03:52:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=362.252624,conversation_content-fragment;desc="conversation_content fragment";dur=552.172075,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=300.649595,nginx;desc="NGINX";dur=1.458643,glb;desc="GLB";dur=102.439719
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=mtU546nx51SK6XACCF%2FI9dL%2FNtmoBb%2B1%2BnnO4CFCSgZrRwB4vuStAz%2Fo40Ok6%2Fa%2B1%2BphtB0juZ%2F4h%2B%2FO8A%2F9Vfp1bkmP%2Bwh4hBlJ5r9ibt5YLPGVuDm2j3OmbWiMRktKqaAXf9HreqxcXmcHvJPeolwVupUI1Zf0mwEYdp5%2FlKTu5nmIlxRVH%2F0XUBxsNKkQIRTge8KON%2BUHKBUG58qDrgeahLmWmQRKBf1nrrwea%2BqA6lYRUvptAUHqAOsahLZP9mJgyIPnPZ6oi0nQaZUN2g%3D%3D--D2yMQlJ0brGhqBVQ--1C5wySzo62U8z0fRBcUqyA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.885891525.1753933955; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 03:52:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 03:52:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ED4E:1892F4:1F5432:2DA261:688AE883
Point to new mapping files for r05 <-> f10 mapping by billsacks · Pull Request #3186 · ESMCI/cime · GitHub
billsacks
added
Responsibility: CESM
Responsibility to manage and accomplish this issue is through CESM
ty: Bug Fix
tp: config
labels
Jul 25, 2019
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 218
Point to new mapping files for r05 <-> f10 mapping #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new mapping files were generated by @mvertens with a recent version of ESMF_RegridWeightGen, with '--ignore_unmapped -m conserve'. The new rof -> lnd map should fix the issue with the old map, that mapping a 1 field from rof -> lnd without normalization leads to non-1 values on the destination. Resolves ESMCI#3185
billsacks
added
Responsibility: CESM
|
I haven't imported the new files to the inputdata repo yet, but will do so once the PR is approved. |
ekluzek
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine of course, as far as I can tell. Note the filename uses a 4-digit year rather than 2-digit. I suppose that's a good change to make though.
|
I have imported the new files. @fischer-ncar feel free to merge this whenever you're ready, noting that it will change answers for cases using the f10 grid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Responsibility: CESM
Responsibility to manage and accomplish this issue is through CESM
tp: config
ty: Bug Fix
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Point to new mapping files for r05 <-> f10 mapping
The new mapping files were generated by @mvertens with a recent version
of ESMF_RegridWeightGen, with '--ignore_unmapped -m conserve'.
The new rof -> lnd map should fix the issue with the old map, that
mapping a 1 field from rof -> lnd without normalization leads to non-1
values on the destination.
Test suite: Cherry-picked the change into the cime version used in ctsm master, then ran
SMS_D_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-defaultwith comparison against master.
Test baseline: ctsm1.0.dev052
Test namelist changes: lnd2rof_fmapname, rof2lnd_fmapname
Test status: greater than roundoff, but probably not climate changing;
only changes cases using the f10 grid (just used for testing)
There are differences in the following CLM fields (these are either directly related to the mapped river volume, or depend on it via methane's dependence on total gridcell water volume):
and in the following cpl fields:
Fixes #3185
User interface changes?: N
Update gh-pages html (Y/N)?: N
Code review: