You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
The preserve-caught-error rule was producing false positives when a caught error was re-thrown using a quoted or computed static "cause" key. For example:
Previously, the rule only recognized unquoted identifier keys and would incorrectly report that the caught error was not preserved.
What changes did you make? (Give an overview)
Replaced the manual property checks with astUtils.getStaticPropertyName(prop) === "cause" to correctly handle all static "cause" keys (unquoted, quoted, and computed).
Added tests covering different forms of static "cause" keys, both valid and invalid.
Is there anything you'd like reviewers to focus on?
mdjermanovic
changed the title
fix: preserve-caught-error should recognize all static "cause" keys
feat: preserve-caught-error should recognize all static "cause" keys
Sep 29, 2025
acceptedThere is consensus among the team that this change meets the criteria for inclusionbugESLint is working incorrectlycontributor poolfeatureThis change adds a new feature to ESLintruleRelates to ESLint's core rules
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
The
preserve-caught-error
rule was producing false positives when a caught error was re-thrown using a quoted or computed static"cause"
key. For example:Previously, the rule only recognized unquoted identifier keys and would incorrectly report that the caught error was not preserved.
What changes did you make? (Give an overview)
astUtils.getStaticPropertyName(prop) === "cause"
to correctly handle all static"cause"
keys (unquoted, quoted, and computed)."cause"
keys, both valid and invalid.Is there anything you'd like reviewers to focus on?