fix: correct no-loss-of-precision false positives for leading zeros (#20164)

fasttime · web-flow · commit a129cced7a86 · 2025-10-01T07:26:43.000+02:00
* fix: correct `no-loss-of-precision` false positives for leading zeros

* revert accidental change
diff --git a/lib/rules/no-loss-of-precision.js b/lib/rules/no-loss-of-precision.js
@@ -124,14 +124,11 @@ module.exports = {
 		 * @returns {Object} the object containing the integer's coefficient and order of magnitude
 		 */
 		function normalizeInteger(stringInteger) {
-			const significantDigits = removeTrailingZeros(
-				removeLeadingZeros(stringInteger),
-			);
+			const trimmedInteger = removeLeadingZeros(stringInteger);
+			const significantDigits = removeTrailingZeros(trimmedInteger);
 
 			return {
-				magnitude: stringInteger.startsWith("0")
-					? stringInteger.length - 2
-					: stringInteger.length - 1,
+				magnitude: trimmedInteger.length - 1,
 				coefficient: addDecimalPointToNumber(significantDigits),
 			};
 		}
@@ -140,7 +137,7 @@ module.exports = {
 		 *
 		 * Converts a float to an object containing the floats's coefficient and order of magnitude
 		 * @param {string} stringFloat the string representation of the float being converted
-		 * @returns {Object} the object containing the integer's coefficient and order of magnitude
+		 * @returns {Object} the object containing the float's coefficient and order of magnitude
 		 */
 		function normalizeFloat(stringFloat) {
 			const trimmedFloat = removeLeadingZeros(stringFloat);
@@ -169,7 +166,7 @@ module.exports = {
 		 * @returns {string} the number converted to scientific notation
 		 */
 		function convertNumberToScientificNotation(stringNumber) {
-			const splitNumber = stringNumber.replace("E", "e").split("e");
+			const splitNumber = stringNumber.split("e");
 			const originalCoefficient = splitNumber[0];
 			const normalizedNumber = stringNumber.includes(".")
 				? normalizeFloat(originalCoefficient)
diff --git a/tests/lib/rules/no-loss-of-precision.js b/tests/lib/rules/no-loss-of-precision.js
@@ -57,6 +57,8 @@ ruleTester.run("no-loss-of-precision", rule, {
 		"var x = 9.0000000000E10",
 		"var x = 019.5",
 		"var x = 0195",
+		"var x = 00195",
+		"var x = 0008",
 		"var x = 0e5",
 
 		{ code: "var x = 12_34_56", languageOptions: { ecmaVersion: 2021 } },
