Breaking: add some rules to eslint:recommended (refs #14673) (#14691)

aladdin-add · web-flow · commit 8cce06cb3988 · 2021-08-05T12:42:30.000-07:00
* no-loss-of-precision
* no-unsafe-optional-chaining
* no-useless-backreference
* no-nonoctal-decimal-escape
diff --git a/conf/eslint-recommended.js b/conf/eslint-recommended.js
@@ -42,9 +42,11 @@ module.exports = {
         "no-inner-declarations": "error",
         "no-invalid-regexp": "error",
         "no-irregular-whitespace": "error",
+        "no-loss-of-precision": "error",
         "no-misleading-character-class": "error",
         "no-mixed-spaces-and-tabs": "error",
         "no-new-symbol": "error",
+        "no-nonoctal-decimal-escape": "error",
         "no-obj-calls": "error",
         "no-octal": "error",
         "no-prototype-builtins": "error",
@@ -60,8 +62,10 @@ module.exports = {
         "no-unreachable": "error",
         "no-unsafe-finally": "error",
         "no-unsafe-negation": "error",
+        "no-unsafe-optional-chaining": "error",
         "no-unused-labels": "error",
         "no-unused-vars": "error",
+        "no-useless-backreference": "error",
         "no-useless-catch": "error",
         "no-useless-escape": "error",
         "no-with": "error",
diff --git a/lib/rules/no-loss-of-precision.js b/lib/rules/no-loss-of-precision.js
@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "disallow literal numbers that lose precision",
             category: "Possible Errors",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/rules/no-loss-of-precision"
         },
         schema: [],
diff --git a/lib/rules/no-nonoctal-decimal-escape.js b/lib/rules/no-nonoctal-decimal-escape.js
@@ -31,7 +31,7 @@ module.exports = {
         docs: {
             description: "disallow `\\8` and `\\9` escape sequences in string literals",
             category: "Best Practices",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/rules/no-nonoctal-decimal-escape",
             suggestion: true
         },
diff --git a/lib/rules/no-unsafe-optional-chaining.js b/lib/rules/no-unsafe-optional-chaining.js
@@ -25,7 +25,7 @@ module.exports = {
         docs: {
             description: "disallow use of optional chaining in contexts where the `undefined` value is not allowed",
             category: "Possible Errors",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/rules/no-unsafe-optional-chaining"
         },
         schema: [{
diff --git a/lib/rules/no-useless-backreference.js b/lib/rules/no-useless-backreference.js
@@ -65,7 +65,7 @@ module.exports = {
         docs: {
             description: "disallow useless backreferences in regular expressions",
             category: "Possible Errors",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/rules/no-useless-backreference"
         },
 
