| CARVIEW |
Select Language
HTTP/2 301
date: Mon, 14 Jul 2025 21:38:05 GMT
content-length: 0
location: https://github.com/dropzone/dropzone/pull/91
server-timing: nginx;desc="NGINX";dur=1.285149,glb;desc="GLB";dur=95.62803
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=DJ%2FjbJBMpVDGy7rFpfXj%2Bl%2F6cL0%2F4lkxtG4ZxikF8jO7P0A5T88d3SZkEbN%2Bva5iibk7o2qKHTrDG3pQ1bXKFYOtvb3VmXL%2FoN8Fmp387qHr5u2iRNlTyKGYzD4QqEaDgWlmwvuj1tAiUAjDm5bgo%2BpdFdx34VgrBWZ8s6lt2fZ5zbUraIBgLfiMBrL%2F4bQabFuqJuj6CUcGVUv6xjnRheTpDzM7Bwv6eLY7uGeOcKzlIJMjLG5msP6meoG%2FMXCWLve6no82g7NbD%2FN9FGlkJQ%3D%3D--%2BW0jaxO4ps8M4OAB--w0JpLzy0SJgvAxOq8cGk7g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1124233862.1752529085; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:38:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:38:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DFA0:3196A1:81C02:B8F5D:687578BD
HTTP/2 200
date: Mon, 14 Jul 2025 21:38:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=313.81284,conversation_content-fragment;desc="conversation_content fragment";dur=720.557192,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=228.052292,nginx;desc="NGINX";dur=0.989976,glb;desc="GLB";dur=95.908909
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DFA0:3196A1:81C18:B8F76:687578BD
Make dropzone message clickable by njx · Pull Request #91 · dropzone/dropzone · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Make dropzone message clickable #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| &.clickable | |||
| cursor pointer | |||
| .message | |||
| .message, .message span | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be necessary, should it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... yes it is. I just now realised that I've never experienced those problems because I always used the substitute image.
enyo
added a commit
that referenced
this pull request
Apr 5, 2013
|
Thanks for the stylus info. I fixed that as well. |
|
I went for a bit of a different approach though. I added a function if evt.target == @element or Dropzone.elementInside evt.target, @element.querySelector ".message" |
|
That makes sense (I was going for a minimal change since I'm not a CoffeeScript expert). However, that probably means you should also change the selector in basic.styl to Thanks for Dropzone by the way--really easy to use and looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In the current build of Dropzone, you can click anywhere in the drop zone to bring up the browse dialog except the "Drop files here or click" message, which is a little odd. This patch should fix that.
I wasn't able to test the patch as-is, because I couldn't build properly with grunt (stylus complained that it couldn't find nib, and the built JS file didn't seem to work). I did test basically the same patch in (a slightly older version of) the checked-in JS file and basic.css, and it worked. So, hopefully it will work for you :)