| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 19:15:57 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=291.187251,conversation_content-fragment;desc="conversation_content fragment";dur=391.615932,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=213.251183,nginx;desc="NGINX";dur=1.115048,glb;desc="GLB";dur=100.878164
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=hn2XCSv6G6pTEVrHwJzOofvUbADATCWc3lcsxk8HOoPBDKfUTWC0NK6BN7wLaa8ZfTuT6WOU82UPEIhwI67a2Q8QLy%2BVCFXKhEurtAoeA7z6lMMBX5laocshpgjmQOvHwyEZxQEYQzPGyjRmqB%2BYlNnsQkae0OksHOCLiHcDOqTxhi75%2B7YbuBD3GHRuFzLquAkQAjWkoUhQZgzizG%2B0SxMIYSS9Qu6dxpbhJKtDkvtKuD7UKAgBjyAngYbXd9whK3PiIqJE5mGWfS2ekuW2dQ%3D%3D--BFjuGPgtSMIl4DZT--L7F%2BkYUv%2FLLEa%2Bx0ADuvRg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.172307717.1753557356; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 19:15:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 19:15:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9AD6:2CB2E7:861634:AD1B01:6885296C
Work around a bug where the tab-line isn't taken into account by Stebalien · Pull Request #115 · emacs-exwm/exwm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 20
Work around a bug where the tab-line isn't taken into account #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Emacs before version 31, window-inside-absolute-pixel-edges returns the wrong y-offset when the per-buffer tab-line is enabled. The tab-line is taken into account when computing the window's height, so we adjust the y-offset after computing the height. Fixed upstream in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75576. * exwm-layout.el (exwm-layout--show): Adjust the window's y-offset to include the tab-line. (Bug #114)
|
It looks like Eli wants to land the patch on master (Emacs 30 is getting real close) so I've configured the check to be Emacs 30 and below. Users compiling from Emacs master will have to wait for the patch to land upstream. |
|
The issue is not that urgent. I think it is better to not delay the Emacs 30 release. For EXWM it shouldn't matter much if we check for version 30 or 31. Or are you aware of other packages or features which are broken by this? I am not sure if tab-line tabs are used widely. I've never used them in contrast to the tab-bar. |
|
I don't think this affects anyone else. I'm just waiting for a final call from the Emacs maintainers before merging this. And yeah, this absolutely should not delay the Emacs 30 release. |
|
The fix was pushed to Emacs master so I'm merging this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In Emacs before version 31, window-inside-absolute-pixel-edges returns the wrong y-offset when the per-buffer tab-line is enabled. The tab-line is taken into account when computing the window's height, so we adjust the y-offset after computing the height.
Fixed upstream in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75576.