| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:09:46 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=292.19904,conversation_content-fragment;desc="conversation_content fragment";dur=688.50992,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=318.360489,nginx;desc="NGINX";dur=1.442307,glb;desc="GLB";dur=101.520295
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RAsE7Xx9MpLZpI27lfaSyVUFl5CQ4ACE9mSBYgySR3ABog8znVfR%2Fs46ZU9ggLkn5tg5x1G6udk9QLoLkRPjGp4oZwCfjRZsubdmZP3IMRQh6zuqdc%2BGjFdW1HaG62WjOfCYOnMUTR359BnHF5%2FfxaHzvtM18ZNGLZ6ppuennidaGEjpHlSIRe%2BXxzfhdMZP7p%2FFhNILo5Vcy8BvSRnn5jImzfu5aY9rkVNHNk56MZheVri%2B7yfL9rLkhETI5UiruxlSX13Cc6GjQSeE05rWDg%3D%3D--ciN67v5r7OqKrNH5--PGgGhOcove5v675cg2lqNw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1375259432.1753466985; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:09:45 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:09:45 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CE6E:14885C:A917A:CFC97:6883C869
Set _NET_ACTIVE_WINDOW to the current EXWM workspace by Stebalien · Pull Request #111 · emacs-exwm/exwm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 20
Set _NET_ACTIVE_WINDOW to the current EXWM workspace #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-X window is selected, set _NET_ACTIVE_WINDOW to the current EXWM workspace (i.e., the Emacs frame containing the selected window). This behavior can be tested with, e.g., `xdotool getactivewindow'. * exwm-input.el (exwm-input--set-active-window): The window ID is now mandatory. (exwm--input-update-focus): When focusing on a workspace, set the active window to the workspace's window ID. (#77)
Stebalien
commented
Jan 2, 2025
| (x-focus-frame frame) | ||
| (exwm-input--set-active-window | ||
| (or (frame-parameter exwm-workspace--current 'exwm-outer-id) | ||
| xcb:Window:None))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should never hit this case but I'm not 100% sure there isn't a race somewhere (e.g., when creating new workspaces).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use exwm-workspace--current here instead of frame, since we called x-focus-frame on frame? Should be the same, right? Instead of the or with xcb:Window:None you could also preserve the old exwm-input--set-active-window calling convention which allows a nil argument, such that the change is overall more minimal.
| @@ -373,23 +373,25 @@ attempt later." | |||
| window) | |||
| (exwm--defer 0 #'exwm-workspace-switch (selected-frame))) | |||
| ;; The focus is still on the current workspace. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is only supposed to cover switching focus within a workspace, not between workspaces. However, from my testing, we hit this case when switching workspaces anyways so there's no need to update _NET_ACTIVE_WINDOW from the other case.
|
I've tested this with multiple workspaces, multiple monitors, floating windows, etc. so I think I've covered most cases. Posframe windows that take focus (e.g., vertico-posframe) treat the current workspace as focused but, IMO, that's fine. |
|
There are two other places in exwm.el and exwm-workspace.el where |
|
|
(merging because I haven't run into any bugs so far) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When a non-X window is selected, set _NET_ACTIVE_WINDOW to the current EXWM workspace (i.e., the Emacs frame containing the selected window). This behavior can be tested with, e.g., `xdotool getactivewindow'.
(exwm--input-update-focus): When focusing on a workspace, set the active window to the workspace's window ID. (Setting _NET_ACTIVE_WINDOW to emacs when non-EXWM buffer in focus #77)