You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
IMO, exwm-input-set-key and exwm-input-set-simuation-key might make sense as autoloads as they might be called from a configuration before enabling EXWM, but I don't feel strongly about that.
Otherwise, EXWM needs to be started before any of these functions are called so autoloads make no sense.
IMO, exwm-input-set-key and exwm-input-set-simuation-key might make sense as autoloads as they might be called from a configuration before enabling EXWM, but I don't feel strongly about that.
In the old exwm-config.el file the variables were set directly, so I think we are safe with not autoloading these commands. There is also the plan to move over to a keymap-based configuration later on.
Otherwise, EXWM needs to be started before any of these functions are called so autoloads make no sense.
Not to forget, the fix is easy enough if users want to use EXWM functions earlier for some reason:
(require'exwm)
For all other users the reduction of autoloads makes it easier to understand how EXWM is supposed to be initialized. Maybe we should also provide a use-package example? I don't use use-package myself anymore, so I am not the best person to provide it, but it will probably have a form like this:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only entry points to EXWM are marked as autoloaded. These are the functions
exwm-enable
andexwm-*-mode
.See #102