[Android] Align dash effect between Border and Shapes (#12693)

jsuarezruiz · mandel-macaque · web-flow · commit 2218065e9eaf · 2023-02-09T11:40:19.000-06:00
* Align dash effect between Border and Shapes on Android

* Update src/Core/src/Graphics/MauiDrawable.Android.cs

Co-authored-by: Manuel de la Pena &lt;mandel@microsoft.com&gt;

---------

Co-authored-by: Manuel de la Pena &lt;mandel@microsoft.com&gt;
diff --git a/src/Core/src/Graphics/MauiDrawable.Android.cs b/src/Core/src/Graphics/MauiDrawable.Android.cs
@@ -270,7 +270,7 @@ public void SetBorderWidth(double strokeWidth)
 
 		public void SetBorderDash(float[]? strokeDashArray, double strokeDashOffset)
 		{
-			if (strokeDashArray == null || strokeDashArray.Length == 0 || strokeDashOffset <= 0)
+			if (strokeDashArray is null || strokeDashArray.Length == 0)
 				_borderPathEffect = null;
 			else
 			{
diff --git a/src/Core/tests/DeviceTests/Handlers/Border/BorderHandlerTests.cs b/src/Core/tests/DeviceTests/Handlers/Border/BorderHandlerTests.cs
@@ -53,6 +53,29 @@ public async Task StrokeInitializesCorrectly(uint color)
 			await ValidateHasColor(border, expected);
 		}
 
+		[Theory(DisplayName = "Dashed Stroke Initializes Correctly")]
+		[InlineData(0xFFFF0000)]
+		[InlineData(0xFF00FF00)]
+		[InlineData(0xFF0000FF)]
+		public async Task DashedStrokeInitializesCorrectly(uint color)
+		{
+			var expected = Color.FromUint(color);
+
+			var border = new BorderStub()
+			{
+				Content = new LabelStub { Text = "Stroke", TextColor = Colors.Black },
+				Shape = new RectangleShapeStub(),
+				Background = new SolidPaintStub(Colors.White),
+				Stroke = new SolidPaintStub(expected),
+				StrokeDashPattern = new float[2] { 1, 1 }, 
+				StrokeThickness = 6,
+				Height = 100,
+				Width = 300
+			};
+
+			await ValidateHasColor(border, expected);
+		}
+
 		[Theory(DisplayName = "StrokeShape Initializes Correctly")]
 		[InlineData("Rectangle")]
 		[InlineData("RoundRectangle")]

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ public void SetBorderWidth(double strokeWidth)`
`270`	`270`
`271`	`271`	`public void SetBorderDash(float[]? strokeDashArray, double strokeDashOffset)`
`272`	`272`	`{`
`273`		`- if (strokeDashArray == null \|\| strokeDashArray.Length == 0 \|\| strokeDashOffset <= 0)`
	`273`	`+ if (strokeDashArray is null \|\| strokeDashArray.Length == 0)`
`274`	`274`	`_borderPathEffect = null;`
`275`	`275`	`else`
`276`	`276`	`{`