CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 11:10:00 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/dotnet/android.git
etag: W/"a2f1931ec07731b6ce31679cf4c465f4"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=18kSTFMfyfCAuElW3q9nhE9TNNfUr2UOEzQju2TWVxajU0j%2BGCYXn1wcvCQqHacZxADNYxbPrx41VJudgkBgu8FuRszpTMePyY7H8WmYRN%2F3GIn1aaOH1NHgQfwEIYqhFZXCeD4kV5D2r%2FGtMvDHKq80acKkPuMx9BGDsYF8ITutM3vP4%2FAGMLUiPAODgns6s2rihXDwbTKmyx8d1Fr%2BW1qnX28xK6T1cF5nvLZGWqOxoYdSgFFlUQ8E5tNwLIX5KjrMbw%2FmMMQqk77K7wbo9w%3D%3D--JeLXvzLxE1QhQIjH--bE1gusTQ0N34jtLQQgDfiA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.507327113.1753614599; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:09:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:09:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E61E:29054:3E44C3:52FF39:68860907
[Xamarin.Android.Build.Tasks] <GenerateJavaStubs/> only MonoAndroid (… · dotnet/android@998fe61 · GitHub
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/ResolveAssemblies.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
Commit 998fe61
[Xamarin.Android.Build.Tasks] <GenerateJavaStubs/> only MonoAndroid (#2643)
Currently the `<GenerateJavaStubs/>` MSBuild task will load and
iterate over NetStandard or PCL assemblies. It looks at all items in
`@(_ResolvedUserAssemblies)` and writes Java stubs if needed.
Instead, let's look at the assembly's "TargetFrameworkIdentifier" --
as known through [`TargetFrameworkAttribute.FrameworkName`][0] --
and *only* do this work for `MonoAndroid`-profile assemblies.
To make this work:
- The `<ResolveAssemblies/>` MSBuild task needs to parse the
"TargetFrameworkIdentifier" and add it to the item metadata for
each assembly.
- `<GenerateJavaStubs/>` should use a subset of
`@(_ResolvedUserAssemblies)` where the "TargetFrameworkIdentifier"
is `MonoAndroid`.
Results:
Before
First: 1200 ms GenerateJavaStubs 1 calls
Incremental: 1047 ms GenerateJavaStubs 1 calls
After
First: 1084 ms GenerateJavaStubs 1 calls
Incremental: 868 ms GenerateJavaStubs 1 calls
This seems to save ~200ms in the Xamarin.Forms integration project in
this repo. Projects using lots of NetStandard/PCL assemblies should
see a bigger benefit.
[0]: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.versioning.targetframeworkattribute.frameworkname?view=netframework-4.7.21 parent d069350 commit 998fe61Copy full SHA for 998fe61
File tree
Expand file treeCollapse file tree
2 files changed
+47
-18
lines changedFilter options
- src/Xamarin.Android.Build.Tasks
- Tasks
Expand file treeCollapse file tree
2 files changed
+47
-18
lines changedsrc/Xamarin.Android.Build.Tasks/Tasks/ResolveAssemblies.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/ResolveAssemblies.cs+40-17Lines changed: 40 additions & 17 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
211 | 211 |
| |
212 | 212 |
| |
213 | 213 |
| |
214 |
| - | |
| 214 | + | |
215 | 215 |
| |
216 | 216 |
| |
217 | 217 |
| |
218 | 218 |
| |
219 | 219 |
| |
220 | 220 |
| |
221 |
| - | |
222 |
| - | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
223 | 229 |
| |
224 | 230 |
| |
225 | 231 |
| |
| |||
257 | 263 |
| |
258 | 264 |
| |
259 | 265 |
| |
260 |
| - | |
| 266 | + | |
261 | 267 |
| |
| 268 | + | |
| 269 | + | |
262 | 270 |
| |
263 | 271 |
| |
264 | 272 |
| |
| |||
275 | 283 |
| |
276 | 284 |
| |
277 | 285 |
| |
| 286 | + | |
278 | 287 |
| |
279 |
| - | |
280 |
| - | |
281 |
| - | |
282 |
| - | |
283 |
| - | |
284 |
| - | |
285 |
| - | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
286 | 306 |
| |
287 | 307 |
| |
288 | 308 |
| |
| |||
336 | 356 |
| |
337 | 357 |
| |
338 | 358 |
| |
339 |
| - | |
340 |
| - | |
| 359 | + | |
341 | 360 |
| |
342 | 361 |
| |
343 |
| - | |
| 362 | + | |
344 | 363 |
| |
345 |
| - | |
346 |
| - | |
347 |
| - | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
348 | 371 |
| |
349 | 372 |
| |
350 | 373 |
| |
|
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets+7-1Lines changed: 7 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2294 | 2294 |
| |
2295 | 2295 |
| |
2296 | 2296 |
| |
| 2297 | + | |
| 2298 | + | |
| 2299 | + | |
| 2300 | + | |
| 2301 | + | |
| 2302 | + | |
2297 | 2303 |
| |
2298 | 2304 |
| |
2299 | 2305 |
| |
| |||
2302 | 2308 |
| |
2303 | 2309 |
| |
2304 | 2310 |
| |
2305 |
| - | |
| 2311 | + | |
2306 | 2312 |
| |
2307 | 2313 |
| |
2308 | 2314 |
| |
|
You can’t perform that action at this time.
0 commit comments